Skip to content

Commit 6eb3c90

Browse files
committed
refactor
1 parent 51674ce commit 6eb3c90

File tree

13 files changed

+149
-89
lines changed

13 files changed

+149
-89
lines changed

src/main/java/com/meilisearch/sdk/Client.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
import com.meilisearch.sdk.exceptions.MeilisearchException;
99
import com.meilisearch.sdk.json.JsonHandler;
1010
import com.meilisearch.sdk.model.*;
11-
import com.meilisearch.sdk.model.batch_dto.Batch;
11+
import com.meilisearch.sdk.model.batch.req.BatchesQuery;
12+
import com.meilisearch.sdk.model.batch.res.Batch;
1213
import java.util.Date;
1314
import java.util.HashMap;
1415
import java.util.Map;

src/main/java/com/meilisearch/sdk/TasksHandler.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
import com.meilisearch.sdk.exceptions.MeilisearchTimeoutException;
55
import com.meilisearch.sdk.http.URLBuilder;
66
import com.meilisearch.sdk.model.*;
7-
import com.meilisearch.sdk.model.batch_dto.Batch;
7+
import com.meilisearch.sdk.model.batch.req.BatchesQuery;
8+
import com.meilisearch.sdk.model.batch.res.Batch;
89
import java.util.Date;
910

1011
/**
@@ -161,7 +162,7 @@ void waitForTask(int taskUid, int timeoutInMs, int intervalInMs) throws Meilisea
161162
}
162163

163164
/**
164-
* Retrieves a batch by its unique identifier.
165+
* Retrieves a batch by uid.
165166
*
166167
* @param uid The unique identifier of the batch.
167168
* @return The Batch object corresponding to the given uid.
@@ -175,7 +176,7 @@ public Batch getBatch(int uid) {
175176
* Retrieves all batches based on the provided query parameters.
176177
*
177178
* @param batchesQuery An instance of BatchesQuery containing filtering criteria.
178-
* @return A CursorResults object containing a list of Batch objects.
179+
* @return A CursorResults object containing a paginated list of Batch objects.
179180
*/
180181
public CursorResults<Batch> getAllBatches(BatchesQuery batchesQuery) {
181182
String urlPath = batchPath().addQuery(batchesQuery.toQuery()).getURL();
@@ -187,11 +188,7 @@ private URLBuilder tasksPath() {
187188
return new URLBuilder("/tasks");
188189
}
189190

190-
/**
191-
* Constructs a URLBuilder instance for the "/batches" API endpoint.
192-
*
193-
* @return A URLBuilder object initialized with the "/batches" path.
194-
*/
191+
/** Constructs a URLBuilder instance for the "/batches" API endpoint. */
195192
private URLBuilder batchPath() {
196193
return new URLBuilder("/batches");
197194
}
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
package com.meilisearch.sdk.enums;
2+
3+
import com.fasterxml.jackson.annotation.JsonValue;
4+
import com.google.gson.annotations.SerializedName;
5+
6+
/**
7+
* Enum for Operation Type
8+
*
9+
* @see <a href="https://www.meilisearch.com/docs/reference/api/tasks#type">API specification</a>
10+
*/
11+
public enum OperationType {
12+
@SerializedName("indexCreation")
13+
INDEX_CREATION("indexCreation"),
14+
@SerializedName("indexUpdate")
15+
INDEX_UPDATE("indexUpdate"),
16+
@SerializedName("indexDeletion")
17+
INDEX_DELETE("indexDeletion"),
18+
@SerializedName("indexSwap")
19+
INDEX_SWAP("indexSwap"),
20+
@SerializedName("documentAdditionOrUpdate")
21+
DOCUMENT_UPSERT("documentAdditionOrUpdate"),
22+
@SerializedName("documentDeletion")
23+
DOCUMENT_DELETE("documentDeletion"),
24+
@SerializedName("settingsUpdate")
25+
SETTINGS_UPDATE("settingsUpdate"),
26+
@SerializedName("dumpCreation")
27+
DUMP_CREATE("dumpCreation"),
28+
@SerializedName("taskCancelation")
29+
TASK_CANCEL("taskCancelation"),
30+
@SerializedName("taskDeletion")
31+
TASK_DELETE("taskDeletion"),
32+
@SerializedName("snapshotCreation")
33+
SNAPSHOT_CREATE("snapshotCreation");
34+
35+
public final String operationType;
36+
37+
OperationType(String operationType) {
38+
this.operationType = operationType;
39+
}
40+
41+
@JsonValue
42+
@Override
43+
public String toString() {
44+
return this.operationType;
45+
}
46+
}

src/main/java/com/meilisearch/sdk/model/BatchResults.java

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/main/java/com/meilisearch/sdk/model/CursorResults.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
import java.util.List;
44
import lombok.Data;
55

6+
/**
7+
* Data structure paginated response Currently used in : Batches.
8+
*
9+
* @see <a href="https://www.meilisearch.com/docs/reference/api/batches#response">API
10+
* specification</a>
11+
*/
612
@Data
713
public class CursorResults<T> {
814
private List<T> results;

src/main/java/com/meilisearch/sdk/model/BatchesQuery.java renamed to src/main/java/com/meilisearch/sdk/model/batch/req/BatchesQuery.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
1-
package com.meilisearch.sdk.model;
1+
package com.meilisearch.sdk.model.batch.req;
22

33
import com.meilisearch.sdk.http.URLBuilder;
44
import java.util.Date;
55
import lombok.Data;
66
import lombok.experimental.Accessors;
77

8+
/**
9+
* Data structure of a query parameter for batches route
10+
*
11+
* @see <a href="https://www.meilisearch.com/docs/reference/api/batches#query-parameters">API
12+
* specification</a>
13+
*/
814
@Data
915
@Accessors(chain = true)
1016
public class BatchesQuery {
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package com.meilisearch.sdk.model.batch.res;
2+
3+
import com.meilisearch.sdk.model.TaskDetails;
4+
import lombok.Data;
5+
6+
/**
7+
* Data structure of the batch object response
8+
*
9+
* @see <a href="https://www.meilisearch.com/docs/reference/api/batches#batch-object">API
10+
* specification</a>
11+
*/
12+
@Data
13+
public class Batch {
14+
private int uid = 0;
15+
private TaskDetails details;
16+
private BatchProgress progress;
17+
private StatDetails stats;
18+
private String startedAt;
19+
private String finishedAt;
20+
private String duration;
21+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package com.meilisearch.sdk.model.batch.res;
2+
3+
import java.util.List;
4+
import lombok.Data;
5+
6+
@Data
7+
class BatchProgress {
8+
private List<StepDetails> steps;
9+
private int percentage;
10+
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
package com.meilisearch.sdk.model.batch.res;
2+
3+
import com.meilisearch.sdk.enums.OperationType;
4+
import com.meilisearch.sdk.model.TaskStatus;
5+
import java.util.Map;
6+
import lombok.Data;
7+
8+
@Data
9+
public class StatDetails {
10+
private int totalNbTasks;
11+
private Map<TaskStatus, Integer> status;
12+
private Map<OperationType, Integer> types;
13+
private Map<String, Integer> indexUids;
14+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package com.meilisearch.sdk.model.batch.res;
2+
3+
import lombok.Data;
4+
5+
@Data
6+
class StepDetails {
7+
private String currentStep;
8+
private int finished;
9+
private int total;
10+
}

0 commit comments

Comments
 (0)