Merge #247

247: Fix rails cache serialization (marshal dump) r=brunoocasali a=anderson

# Pull Request

## Related issue
Fixes #246

## What does this PR do?
- Fix rails cache serialization (marshal dump) from database result after Meilisearch result.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Co-authored-by: Anderson Peligrini <[email protected]>

Author: bors[bot]

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-03-06 23:49:40 UTC using RuboCop version 1.27.0.
+# on 2023-03-17 21:09:14 UTC using RuboCop version 1.27.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -49,7 +49,7 @@ Metrics/BlockLength:
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 157
+  Max: 156
 
 # Offense count: 9
 # Configuration parameters: IgnoredMethods.
@@ -102,8 +102,7 @@ RSpec/DescribeClass:
   Exclude:
     - 'spec/integration_spec.rb'
 
-
-# Offense count: 34
+# Offense count: 35
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 19
@@ -140,6 +139,11 @@ RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/configuration_spec.rb'
 
+# Offense count: 1
+Security/MarshalLoad:
+  Exclude:
+    - 'spec/integration_spec.rb'
+
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.

lib/meilisearch-rails.rb

@@ -59,7 +59,6 @@ class IndexSettings
         attributesToHighlight
         attributesToCrop
         cropLength
-        faceting
         pagination
         faceting
         typoTolerance
@@ -599,13 +598,6 @@ def ms_raw_search(q, params = {})
       end
 
       module AdditionalMethods
-        def self.extended(base)
-          class << base
-            alias_method :raw_answer, :ms_raw_answer unless method_defined? :raw_answer
-            alias_method :facets_distribution, :ms_facets_distribution unless method_defined? :facets_distribution
-          end
-        end
-
         def ms_raw_answer
           @ms_json
         end
@@ -614,6 +606,9 @@ def ms_facets_distribution
           @ms_json['facetDistribution']
         end
 
+        alias raw_answer ms_raw_answer unless method_defined? :raw_answer
+        alias facets_distribution ms_facets_distribution unless method_defined? :facets_distribution
+
         private
 
         def ms_init_raw_answer(json)

spec/integration_spec.rb

@@ -610,6 +610,47 @@
     expect(genres.size).to be > 3
     expect(results.facets_distribution['genre'].size).to eq(3)
   end
+
+  context 'with Marshal serialization' do
+    let(:found_books) { Book.search('*') }
+    let(:marshaled_books) { Marshal.dump(found_books) }
+
+    it 'returns all books in the marshaled format' do
+      # Perform the search and marshal the results
+      expect(marshaled_books).to be_present
+
+      # Load the marshaled data and check the content
+      loaded_books = Marshal.load(marshaled_books)
+      expect(loaded_books).to match_array(found_books)
+    end
+  end
+
+  context 'with Rails caching' do
+    let(:memory_store) { ActiveSupport::Cache.lookup_store(:memory_store) }
+    let(:cache) { Rails.cache }
+
+    let(:search_query) { '*' }
+    let(:cache_key) { "book_search:#{search_query}" }
+
+    before do
+      allow(Rails).to receive(:cache).and_return(memory_store)
+      Rails.cache.clear
+    end
+
+    it 'caches the search results' do
+      # Ensure the cache is empty before the test
+      expect(Rails.cache.read(cache_key)).to be_nil
+
+      # Perform the search and cache the results
+      Rails.cache.fetch(cache_key) do
+        Book.search(search_query)
+      end
+
+      # Check if the search result is cached
+      not_cached_books = Book.search(search_query)
+      expect(Rails.cache.read(cache_key)).to match_array(not_cached_books)
+    end
+  end
 end
 
 describe 'Movie' do