Skip to content

Commit 5f177c6

Browse files
bors[bot]jitingcn
andauthored
Merge #94
94: Upgrade rspec version to 3.x r=brunoocasali a=jitingcn Fixes #93 Co-authored-by: Jiting <[email protected]> Co-authored-by: 寂听 <[email protected]>
2 parents bdabe3b + f1bfd37 commit 5f177c6

File tree

4 files changed

+92
-98
lines changed

4 files changed

+92
-98
lines changed

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Style/FrozenStringLiteralComment:
2929
Enabled: false
3030

3131
RSpec/MultipleExpectations:
32-
Max: 5
32+
Enabled: false
3333

3434
Metrics/BlockLength:
3535
Enabled: true

.rubocop_todo.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2021-11-18 14:59:50 UTC using RuboCop version 1.23.0.
3+
# on 2022-01-07 22:37:10 UTC using RuboCop version 1.24.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -24,6 +24,7 @@ Layout/BlockAlignment:
2424

2525
# Offense count: 2
2626
# Cop supports --auto-correct.
27+
# Configuration parameters: AllowForAlignment.
2728
Layout/CommentIndentation:
2829
Exclude:
2930
- 'lib/meilisearch-rails.rb'
@@ -63,12 +64,6 @@ Lint/UnusedMethodArgument:
6364
Exclude:
6465
- 'lib/meilisearch-rails.rb'
6566

66-
# Offense count: 15
67-
# Configuration parameters: CheckForMethodsWithNoSideEffects.
68-
Lint/Void:
69-
Exclude:
70-
- 'spec/integration_spec.rb'
71-
7267
# Offense count: 10
7368
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
7469
Metrics/AbcSize:
@@ -187,12 +182,11 @@ Style/GuardClause:
187182
Exclude:
188183
- 'lib/meilisearch-rails.rb'
189184

190-
# Offense count: 9
185+
# Offense count: 8
191186
# Cop supports --auto-correct.
192187
Style/IfUnlessModifier:
193188
Exclude:
194189
- 'lib/meilisearch-rails.rb'
195-
- 'spec/integration_spec.rb'
196190

197191
# Offense count: 1
198192
# Cop supports --auto-correct.
@@ -201,6 +195,12 @@ Style/InverseMethods:
201195
Exclude:
202196
- 'lib/meilisearch-rails.rb'
203197

198+
# Offense count: 2
199+
# Cop supports --auto-correct.
200+
Style/MapToHash:
201+
Exclude:
202+
- 'lib/meilisearch-rails.rb'
203+
204204
# Offense count: 8
205205
# Configuration parameters: AllowedMethods.
206206
# AllowedMethods: respond_to_missing?
@@ -214,9 +214,9 @@ Style/RescueModifier:
214214
Exclude:
215215
- 'lib/meilisearch-rails.rb'
216216

217-
# Offense count: 10
217+
# Offense count: 11
218218
# Cop supports --auto-correct.
219219
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
220220
# URISchemes: http, https
221221
Layout/LineLength:
222-
Max: 264
222+
Max: 269

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ group :test do
2828
gem 'activerecord-jdbc-adapter', platform: :jruby
2929
gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
3030
gem 'jdbc-sqlite3', platform: :jruby
31-
gem 'rspec', '>= 2.5.0', '< 3.0'
31+
gem 'rspec', '~> 3.0'
3232
gem 'simplecov', require: 'false'
3333

3434
gem 'byebug'

0 commit comments

Comments
 (0)