-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support federated search #389
Comments
Would this rely on this PR or is the library sufficiently divergent? |
@wesharper It does, I pinged the author of the PR. Of course there's nothing preventing me from implementing it on this gem before the PR is done, but I think it would violate the spirit of FOSS collaboration. |
@ellnix totally agree here. Happy to support any way I can, we've been antsy to start using this! |
@ellnix The PR has been completed! 🎉 I'm really looking forward to this feature, but I don’t want to rush anyone. Do you have any estimate on when the adjustment for the separate federated search path will be made? |
@pozelli probably today, I can't say when it will get merged though. |
@ellnix Thank you so much. From what I'm seeing, I think this can solve my problem, which is caused by having only one pagination for each model. If I force the non-federated multi-search results to be an array (to_a), there will be cases where the pages won't fit properly. I need a single pagination for different models - that is, the federated search. |
@ellnix Hi! Hope you are well. Will FederatedSearchResult support pagination backends? For example, I added the following methods to the class:
|
I will look into it right now, the endpoint doesn't support the regular pagination options that |
In our current state, the multi-search path is acting as a sort of federated search, except without proper ranking rules.
We should deprecate the old
#each
and#to_a
on MultiSearchResult and add a separate path for federated search.The text was updated successfully, but these errors were encountered: