Fix will_paginate crash when Meilisearch disabled #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Meilisearch::Rails.active? as an alternative to checking that the objects being replaced are actually NullObject. For an alternative solution see meilisearch#383 The advantage of this approach is that NullObject remains opaque and requires no special treatment, and the logic is much easier to follow (in my opinion).
ellnix
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 88.96% 89.15% +0.18%
==========================================
Files 13 13
Lines 761 765 +4
==========================================
+ Hits 677 682 +5
+ Misses 84 83 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brunoocasali
approved these changes
Feb 5, 2025
Member
brunoocasali
left a comment
brunoocasali
left a comment
There was a problem hiding this comment.
LGTM!
This solution is way clearer than the previous @ellnix :D
Contributor
Author
|
bors merge |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #382
Using
Meilisearch::Rails.active?as an alternative to checking that the objects being replaced are actuallyNullObject.For an alternative solution see #383
The advantage of this approach is that NullObject remains opaque and requires no special treatment, and the logic is much easier to follow (in my opinion).