Skip to content

Fix will_paginate crash when Meilisearch disabled #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix will_paginate crash when Meilisearch disabled #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae9961
Test for will_paginate crash when Meilisearch is disabled
ellnix Jan 13, 2025
d3cce03
Fix will_paginate crash when Meilisearch disabled
ellnix Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/meilisearch/rails/pagination/will_paginate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ module Rails
module Pagination
class WillPaginate
def self.create(results, total_hits, options = {})
unless MeiliSearch::Rails.active?
total_hits = 0
options[:page] = 1
options[:per_page] = 1
end

::WillPaginate::Collection.create(options[:page], options[:per_page], total_hits) do |pager|
pager.replace results
end
Expand Down
11 changes: 11 additions & 0 deletions spec/pagination/will_paginate_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,15 @@
it 'respects max_total_hits' do
expect(Movie.search('*').count).to eq(5)
end

it 'does not crash when meilisearch is disabled' do
MeiliSearch::Rails.configuration[:active] = false

expect do
Movie.search ''
end.not_to raise_error

ensure
MeiliSearch::Rails.configuration[:active] = true
end
end
Loading