Skip to content

Allow custom group names in multi search #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Allow custom group names in multi search #391

merged 3 commits into from
Mar 12, 2025

Conversation

@ellnix
Copy link
Contributor

@ellnix ellnix commented Jan 27, 2025 •
edited
Loading

Related issue

Fixes #364

Todo:

  • Update README
  • Test Result class
  • Refactor

Two more issues remain in multi search after gets completed: #362 and #389

@ellnix
Add index_name argument to multi_search
e1d210e 
Allows for naming the group of results differently from the name of the
index being searched, therefore allowing the same index to be searched
multiple times with different options.
@codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (5c408f1) to head (38730fb).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   89.13%   89.48%   +0.34%     
==========================================
  Files          13       13              
  Lines         764      770       +6     
==========================================
+ Hits          681      689       +8     
+ Misses         83       81       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ellnix
Update README with new multi search feature
3734a11 
Federated search can follow right after multi search when it is added.
@ellnix ellnix force-pushed the multi_search_enhancement branch from ee3715f to 3734a11 Compare January 30, 2025 15:09
@ellnix
Deprecate flattened access on multi search results
38730fb 
Update #each to mimmick #each_result, not #each_hit
@ellnix ellnix marked this pull request as ready for review February 1, 2025 19:44
pozelli
pozelli approved these changes Feb 4, 2025
View reviewed changes
Copy link

@pozelli pozelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@pozelli pozelli mentioned this pull request Feb 26, 2025
Open
@ellnix
Copy link
Contributor Author

ellnix commented Mar 12, 2025

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Mar 12, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit a3675cb into meilisearch:main Mar 12, 2025
12 checks passed
@ellnix ellnix added the enhancement New feature or request label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

+1 more reviewer

@pozelli pozelli pozelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for multiple searches of the same index in Multi Search

3 participants

@ellnix @brunoocasali @pozelli