Refactor multi search specs

[ellnix]

• These tests were particularly slow, this is about a 50% reduction in time to complete (as reported by rspec).
• In addition refactored to clean up deprecation warnings from test output

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (5450df2) to head (8b4e067).
Report is 22 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          13       13           
  Lines         775      775           
=======================================
  Hits          694      694           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ellnix]

+cc @wesharper if you would like to review.

[wesharper]

Looks good! I like the insert_all pattern. We've had issues in our own app with individual create! calls slowing down tests for us.

[brunoocasali]

Inserts multiple records into the database in a single SQL INSERT statement. It does not instantiate any models nor does it trigger Active Record callbacks or validations. Though passed values go through Active Record’s type casting and serialization.

Interesting that you create the records then you reindex the model, very clever!

[ellnix]

Thanks!

It's a method used very often in seed files, you can imagine that with a lot more records it would be a non-trivial amount of memory and computation to instantiate a ActiveRecord object for all of them.

I'm not really very happy with the solution here, I think it's a little bit undercooked, but I'm saving any refactoring for the inevitable PR where I probably make every test file into an rspec behavior so that I can apply it to every storage backend (AR, Sequel, Mongo).

[ellnix]

bors merge

[meili-bors]

Build succeeded:

• integration-tests (Rails 6.1 with Ruby 3.4)
• integration-tests (Rails 6.1 with Ruby 3.2)
• integration-tests (Rails 7 with Ruby 3.2)
• linter-check
• integration-tests (Rails 7 with Ruby 3.4)
• integration-tests (Rails 6.1 with Ruby 3.3)
• smoke-test
• integration-tests (Rails 7 with Ruby 3.3)