Skip to content

Conversation

@ellnix
Copy link
Contributor

@ellnix ellnix commented Mar 21, 2025

This allows rspec to "remember" the last test run, allowing for commands like rspec --only-failures, which should improve developer UX.

Picked spec/tmp/examples.txt since it's idiomatic to call this file examples.txt and spec/tmp was already in the gitignore.

It's a small thing but I don't think there's an argument against having it.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (b5d918f) to head (bce1eaf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          13       13           
  Lines         776      776           
=======================================
  Hits          695      695           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This allows rspec to "remember" the last test run, allowing for commands
like `rspec --only-failures`, which should improve developer UX.

Picked `spec/tmp/examples.txt` since it's idiomatic to call this file
examples.txt and `spec/tmp` was already in the gitignore.

It's a small thing but I don't think there's an argument against having
it.
@ellnix ellnix force-pushed the rspec-persistence-file branch from beb8543 to bce1eaf Compare March 21, 2025 16:24
@ellnix ellnix added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Mar 21, 2025
@ellnix ellnix requested a review from brunoocasali March 21, 2025 17:06
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this config, very useful indeed!

@ellnix
Copy link
Contributor Author

ellnix commented Mar 24, 2025

bors merge

@meili-bors meili-bors bot merged commit 8eefc53 into meilisearch:main Mar 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants