Skip to content

Remove checks on conditions in the 'ms_must_reindex?' method #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove checks on conditions in the 'ms_must_reindex?' method #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/meilisearch-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,19 +765,6 @@ def ms_must_reindex?(document)
return true if ms_attribute_changed?(document, k)
# return true if !document.respond_to?(changed_method) || document.send(changed_method)
end
[options[:if], options[:unless]].each do |condition|
case condition
when nil
return false
when String, Symbol
return true if ms_attribute_changed?(document, condition)
else
# if the :if, :unless condition is a anything else,
# we have no idea whether we should reindex or not
# let's always reindex then
return true
end
end
end

# By default, we don't reindex
Expand Down