Small corrections for Bin and Dynamic Pads code examples (#94)

drewknab · web-flow · commit dd8759729c52 · 2024-06-25T14:32:45.000+02:00
* small changes to the code samples

* Correction based on review comments
diff --git a/basic_pipeline_extension/02_Bin.md b/basic_pipeline_extension/02_Bin.md
@@ -34,7 +34,7 @@ defmodule Basic.Bin do
     spec = [
       child(:input, %Basic.Elements.Source{location: options.input_filename})
       |> child(:ordering_buffer, Basic.Elements.OrderingBuffer)
-      |> to(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4}) 
+      |> child(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4}) 
       |> bin_output(:output)
     ]
 
diff --git a/basic_pipeline_extension/03_DynamicPads.md b/basic_pipeline_extension/03_DynamicPads.md
@@ -42,7 +42,7 @@ The very first thing we need to do is to use the `def_input_pads` appropriately.
 ...
 def_input_pad :input, 
    demand_unit: :buffers, 
-   flow_control: :pull, 
+   flow_control: :manual, 
    availability: :on_request, 
    accepted_format: %Basic.Formats.Frame{encoding: :utf8}
 ...

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ defmodule Basic.Bin do`
`34`	`34`	`spec = [`
`35`	`35`	`child(:input, %Basic.Elements.Source{location: options.input_filename})`
`36`	`36`	`\|> child(:ordering_buffer, Basic.Elements.OrderingBuffer)`
`37`		`- \|> to(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4})`
	`37`	`+ \|> child(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4})`
`38`	`38`	`\|> bin_output(:output)`
`39`	`39`	`]`
`40`	`40`