Fix export_util.py to encode in the UTF-8 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imilinovic
approved these changes
Mar 21, 2025
|
Josipmrden
pushed a commit
that referenced
this pull request
Mar 24, 2025
Co-authored-by: Ivan Milinović <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* Add migration from neo4j * Update migration * Add labels for migration from neo4j * added PR test to merge_group (#571) * Fix export encoding to UTF-8 (#554) Co-authored-by: Ivan Milinović <[email protected]> * Add constants for connection * Refactor module * Address PR comments --------- Co-authored-by: Dr Matt James <[email protected]> Co-authored-by: Ante Javor <[email protected]> Co-authored-by: Ivan Milinović <[email protected]>
gitbuda
added
Docs - changelog only
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
export_utilquery module didn't specify the export encoding. If your data had special characters not supported by ASCII, they would be saved as garbage in the exported file, or the export would fail. We have fixed this by predefining the UTF-8 encoding in the export utility to support special characters. #554Pull request type
Related issues
Closes: #553
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
Documentation checklist
export_utilquery module didn't specify the export encoding. If your data had special characters not supported by ASCII, they would be saved as garbage in the exported file, or the export would fail. We have fixed this by predefining the UTF-8 encoding in the export utility to support special characters #554