Skip to content

This plugin doesn't work without http_proxy #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toru-takahashi opened this issue Apr 19, 2016 · 3 comments
Open

This plugin doesn't work without http_proxy #13

toru-takahashi opened this issue Apr 19, 2016 · 3 comments

Comments

@toru-takahashi
Copy link

Currently, the plugin doesn't work when user doesn't use http_proxy.
It looks this change affect it.
fa83a87

irb(main):001:0> (proxy,proxy_port) = ENV['http_proxy'].split(':')
NoMethodError: undefined method `split' for nil:NilClass
    from (irb):1
    from /Users/.../.rbenv/versions/2.3.0/bin/irb:11:in `<main>'
irb(main):002:0>
@toru-takahashi
Copy link
Author

This PR would fix this issue.
#11

@nathanhruby
Copy link

#12 would also fix this issue, it seems. Either way, #9 seems to add a requirement for a proxy which I think was not the intention.

Would be great to get this fixed.

@nitish661401869
Copy link

nitish661401869 commented Oct 27, 2016

@memorycraft @mlin could you please let us know when you intend to resolve this issue by merging the requested PR(s) ?

We need the fix for our code to not blow up.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants