Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in Arrow library #361

Closed
Hugo-Polloli opened this issue Mar 7, 2021 · 0 comments
Closed

Breaking changes in Arrow library #361

Hugo-Polloli opened this issue Mar 7, 2021 · 0 comments

Comments

@Hugo-Polloli
Copy link
Contributor

Hugo-Polloli commented Mar 7, 2021

Hi,
Every instance of using dates from the Arrow library might be subject to breaking changes as per arrow-py/arrow#832.

The most blatant one I've run into stems from point 2 and 3 of aforementioned list of breaking changes. See

begin_time = begin_time.timestamp * 1000
and others.

There could either be fixed using a requirement such as arrow<1.0.0 or update Cassiopeia according to said changes. I will try to go over those and if possible provide a PR.

Edit: last commit is just about this version pin, somehow my pip install didn't care, I will still attempt to provide a PR fitting Arrow changes and removing the need of a version pin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants