Skip to content

Commit 2c574ed

Browse files
[PHP tests] Remove non-standard PHP memory leak test (grpc#34257)
This test is not giving us good signals while adding some long term maintenance cost. The way the test is set up and run was not standard. There are other sanitizer tests to test for memory leaks.
1 parent a5e9fee commit 2c574ed

File tree

2 files changed

+0
-97
lines changed

2 files changed

+0
-97
lines changed

src/php/bin/run_tests.sh

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,3 @@ if [[ "$SKIP_PERSISTENT_CHANNEL_TESTS" != "true" ]]; then
3838
$(which php) $extension_dir -d max_execution_time=300 $(which phpunit) -v --debug \
3939
../tests/unit_tests/PersistentChannelTests
4040
fi
41-
42-
export ZEND_DONT_UNLOAD_MODULES=1
43-
export USE_ZEND_ALLOC=0
44-
# Detect whether valgrind is executable
45-
if [ -x "$(command -v valgrind)" ]; then
46-
# skip the memory leak test on ARM64
47-
# TODO(jtattermusch): reenable the test once https://github.com/grpc/grpc/issues/29098 is fixed.
48-
if [ "$(uname -m)" != "aarch64" ]; then
49-
$(which valgrind) --error-exitcode=10 --leak-check=yes \
50-
--errors-for-leak-kinds=definite \
51-
-v \
52-
--num-callers=30 \
53-
--suppressions=../tests/MemoryLeakTest/ignore_leaks.supp \
54-
$VALGRIND_UNDEF_VALUE_ERRORS \
55-
$(which php) $extension_dir -d max_execution_time=300 \
56-
../tests/MemoryLeakTest/MemoryLeakTest.php
57-
fi
58-
fi
59-

src/php/tests/MemoryLeakTest/MemoryLeakTest.php

Lines changed: 0 additions & 78 deletions
This file was deleted.

0 commit comments

Comments
 (0)