Skip to content

Commit 1b045be

Browse files
committed
fix linter warnings
1 parent 07fc991 commit 1b045be

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

meshtastic/powermon/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Support for logging from power meters/supplies."""
22

3-
from .power_supply import PowerMeter, PowerSupply, PowerError
4-
from .riden import RidenPowerSupply
3+
from .power_supply import PowerError, PowerMeter, PowerSupply
54
from .ppk2 import PPK2PowerSupply
6-
from .sim import SimPowerSupply
5+
from .riden import RidenPowerSupply
6+
from .sim import SimPowerSupply

meshtastic/powermon/ppk2.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""code logging power consumption of meshtastic devices."""
22

33
import logging
4-
from typing import *
4+
from typing import Optional
55

66
from ppk2_api import ppk2_api
77

@@ -56,5 +56,3 @@ def powerOn(self):
5656
def powerOff(self):
5757
"""Power off the supply."""
5858
self.r.toggle_DUT_power("OFF")
59-
60-

meshtastic/powermon/sim.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22

33
import math
44
import time
5-
from typing import *
65

7-
from .power_supply import PowerError, PowerSupply
6+
from .power_supply import PowerSupply
87

98

109
class SimPowerSupply(PowerSupply):

meshtastic/slog/arrow.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
"""Utilities for Apache Arrow serialization."""
2+
13
import pyarrow as pa
24

35
chunk_size = 1000 # disk writes are batched based on this number of rows

meshtastic/slog/slog.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
import atexit
44
import logging
5+
import os
56
import re
67
import threading
78
import time
8-
import os
99
from dataclasses import dataclass
1010
from datetime import datetime
1111
from typing import Optional
@@ -18,7 +18,6 @@
1818
from meshtastic.powermon import PowerMeter
1919

2020
from .arrow import ArrowWriter
21-
import os
2221

2322

2423
@dataclass(init=False)
@@ -58,7 +57,9 @@ def __init__(self, pMeter: PowerMeter, file_path: str, interval=0.2) -> None:
5857
self.writer = ArrowWriter(file_path)
5958
self.interval = interval
6059
self.is_logging = True
61-
self.thread = threading.Thread(target=self._logging_thread, name="PowerLogger", daemon=True)
60+
self.thread = threading.Thread(
61+
target=self._logging_thread, name="PowerLogger", daemon=True
62+
)
6263
self.thread.start()
6364

6465
def _logging_thread(self) -> None:
@@ -92,10 +93,9 @@ def __init__(self, client: MeshInterface, dir_path: str) -> None:
9293
"""
9394
self.client = client
9495
self.writer = ArrowWriter(f"{dir_path}/slog.arrow")
95-
# trunk-ignore(pylint/R1732)
9696
self.raw_file = open(
9797
f"{dir_path}/raw.txt", "w", encoding="utf8"
98-
)
98+
) # pylint: disable=consider-using-with
9999
self.listener = pub.subscribe(self._onLogMessage, TOPIC_MESHTASTIC_LOG_LINE)
100100

101101
def close(self) -> None:
@@ -163,15 +163,16 @@ def __init__(
163163
self.power_logger = None
164164

165165
# Store a lambda so we can find it again to unregister
166-
self.atexit_handler = lambda: self.close()
167-
atexit.register(self.close)
166+
self.atexit_handler = lambda: self.close() # pylint: disable=unnecessary-lambda
168167

169168
def close(self) -> None:
170169
"""Close the log set."""
171170

172171
if self.slog_logger:
173172
logging.info(f"Closing slogs in {self.dir_name}")
174-
atexit.unregister(self.atexit_handler) # docs say it will silently ignore if not found
173+
atexit.unregister(
174+
self.atexit_handler
175+
) # docs say it will silently ignore if not found
175176
self.slog_logger.close()
176177
if self.power_logger:
177178
self.power_logger.close()

0 commit comments

Comments
 (0)