Skip to content

Commit 402622f

Browse files
committed
fix type warnings
1 parent 2202414 commit 402622f

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

meshtastic/powermon/ppk2.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
"""code logging power consumption of meshtastic devices."""
1+
"""Classes for logging power consumption of meshtastic devices."""
22

33
import logging
44
from typing import Optional
55

6-
from ppk2_api import ppk2_api
6+
from ppk2_api import ppk2_api # type: ignore[import-untyped]
77

88
from .power_supply import PowerError, PowerSupply
99

meshtastic/slog/arrow.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def __init__(self, file_name: str):
1313
1414
file_name (str): The name of the file to write to.
1515
"""
16-
self.sink = pa.OSFile(file_name, "wb")
16+
self.sink = pa.OSFile(file_name, "wb") # type: ignore
1717
self.new_rows: list[dict] = []
1818
self.schema: pa.Schema | None = None # haven't yet learned the schema
1919
self.writer: pa.RecordBatchFileWriter | None = None

meshtastic/slog/slog.py

+9-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from datetime import datetime
1111
from typing import Optional
1212

13-
import parse
13+
import parse # type: ignore[import-untyped]
1414
import platformdirs
1515
from pubsub import pub # type: ignore[import-untyped]
1616

@@ -25,7 +25,7 @@ class LogDef:
2525
"""Log definition."""
2626

2727
code: str # i.e. PM or B or whatever... see meshtastic slog documentation
28-
format: str # A format string that can be used to parse the arguments
28+
format: parse.Parser # A format string that can be used to parse the arguments
2929

3030
def __init__(self, code: str, fmt: str) -> None:
3131
"""Initialize the LogDef object.
@@ -138,7 +138,7 @@ def __init__(
138138
self,
139139
client: MeshInterface,
140140
dir_name: Optional[str] = None,
141-
power_meter: PowerMeter = None,
141+
power_meter: Optional[PowerMeter] = None,
142142
) -> None:
143143
"""Initialize the PowerMonClient object.
144144
@@ -156,11 +156,12 @@ def __init__(
156156

157157
logging.info(f"Writing slogs to {dir_name}")
158158

159-
self.slog_logger = StructuredLogger(client, self.dir_name)
160-
if power_meter:
161-
self.power_logger = PowerLogger(power_meter, f"{self.dir_name}/power.arrow")
162-
else:
163-
self.power_logger = None
159+
self.slog_logger: Optional[StructuredLogger] = StructuredLogger(client, self.dir_name)
160+
self.power_logger: Optional[PowerLogger] = (
161+
None
162+
if not power_meter
163+
else PowerLogger(power_meter, f"{self.dir_name}/power.arrow")
164+
)
164165

165166
# Store a lambda so we can find it again to unregister
166167
self.atexit_handler = lambda: self.close() # pylint: disable=unnecessary-lambda

poetry.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ riden = { git = "https://github.com/geeksville/riden.git#1.2.1" }
2626
parse = "^1.20.2"
2727
ppk2-api = "^0.9.2"
2828
pyarrow = "^16.1.0"
29-
pyarrow-stubs = "^10.0.1.7"
3029
platformdirs = "^4.2.2"
3130

3231
[tool.poetry.group.dev.dependencies]
@@ -45,6 +44,7 @@ types-tabulate = "^0.9.0.20240106"
4544
types-requests = "^2.31.0.20240406"
4645
types-setuptools = "^69.5.0.20240423"
4746
types-pyyaml = "^6.0.12.20240311"
47+
pyarrow-stubs = "^10.0.1.7"
4848

4949
[tool.poetry.extras]
5050
tunnel = ["pytap2"]

0 commit comments

Comments
 (0)