Skip to content

Commit 50a2e18

Browse files
committed
* Gets rid of formatting issues in tests.
* Triple quotes json test fixtures for better readability. * Removes ignores from pycodestyle.
1 parent f667e71 commit 50a2e18

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

messagebird/serde.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
import json
2-
import sys
32

43

54
def json_serialize(obj):
6-
if sys.version_info > (3, 0):
7-
try:
8-
return json.dumps(obj, ensure_ascii=False).encode('utf-8')
9-
except TypeError:
10-
return json.dumps(obj, default=lambda o: o.__dict__, ensure_ascii=False).encode('utf-8')
11-
else:
12-
try:
13-
return json.dumps(obj, ensure_ascii=False, encoding='utf-8')
14-
except TypeError:
15-
return json.dumps(obj, default=lambda o: o.__dict__, ensure_ascii=False, encoding='utf-8')
5+
try:
6+
return json.dumps(obj, ensure_ascii=False).encode('utf-8')
7+
except TypeError:
8+
return json.dumps(obj, default=lambda o: o.__dict__, ensure_ascii=False).encode('utf-8')

tests/test_serde.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,15 @@
11
# coding=utf-8
2-
import sys
32
import unittest
43

54
from messagebird.serde import json_serialize
65

76

87
class TestJSONSerDe(unittest.TestCase):
98

10-
@staticmethod
11-
def encode_if_py3(s):
12-
if sys.version_info > (3, 0):
13-
return s.encode('utf-8')
14-
else:
15-
return s
16-
179
def test_tr_check(self):
1810
self.assertEqual(json_serialize({'body': 'Pijamalı hasta, yağız şoföre çabucak güvendi.'}),
19-
self.encode_if_py3("""{"body": "Pijamalı hasta, yağız şoföre çabucak güvendi."}"""))
11+
"""{"body": "Pijamalı hasta, yağız şoföre çabucak güvendi."}""".encode("utf-8"))
2012

2113
def test_jp_check(self):
2214
self.assertEqual(json_serialize({'body': 'いろはにほへとちりぬるを'}),
23-
self.encode_if_py3("""{"body": "いろはにほへとちりぬるを"}"""))
15+
"""{"body": "いろはにほへとちりぬるを"}""".encode("utf-8"))

0 commit comments

Comments
 (0)