bugfix

Jerome · Jerome · commit db115b4b32fd · 2021-03-03T08:46:49.000+01:00
diff --git a/changelog.md b/changelog.md
@@ -1,6 +1,10 @@
 CHANGELOG
 ---------
 
+##1.1.7
+#### Bugfix
+- invalid `dynamic_select` component value
+
 ##1.1.6
 #### Feature
 - added `dynamic_select` component, list values from other field in post or in options
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name":"metabolism/acf-extensions",
-  "version": "1.1.6",
+  "version": "1.1.7",
   "type": "wordpress-plugin",
   "description": "ACF Extensions plugin with component, components, hidden field, dynamic select and latest posts field",
   "license": "GPL-3.0-or-later"
diff --git a/fields/class-acf-field-dynamic_select.php b/fields/class-acf-field-dynamic_select.php
@@ -29,8 +29,11 @@ function render_field( $field ) {
 
 					$choice = $other_field_value[$field_key[1]]??'';
 
-					if( strlen($choice) )
-						$choices[] = $other_field_value[$field_key[1]];
+					if( strlen($choice) ){
+
+						$choice = $other_field_value[$field_key[1]];
+						$choices[sanitize_title($choice)] = $choice;
+					}
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name":"metabolism/acf-extensions",`
`3`		`- "version": "1.1.6",`
	`3`	`+ "version": "1.1.7",`
`4`	`4`	`"type": "wordpress-plugin",`
`5`	`5`	`"description": "ACF Extensions plugin with component, components, hidden field, dynamic select and latest posts field",`
`6`	`6`	`"license": "GPL-3.0-or-later"`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,11 @@ function render_field( $field ) {`
`29`	`29`
`30`	`30`	`$choice = $other_field_value[$field_key[1]]??'';`
`31`	`31`
`32`		`- if( strlen($choice) )`
`33`		`- $choices[] = $other_field_value[$field_key[1]];`
	`32`	`+ if( strlen($choice) ){`
	`33`	`+`
	`34`	`+ $choice = $other_field_value[$field_key[1]];`
	`35`	`+ $choices[sanitize_title($choice)] = $choice;`
	`36`	`+ }`
`34`	`37`	`}`
`35`	`38`	`}`
`36`	`39`