remove special check for hidden packages

Module::Metadata and Parse::PMFile will already exclude modules using
the 'hide from PAUSE' trick. There is no need to add an additional check
on top of that.

Author: haarg

lib/MetaCPAN/Document/File.pm

@@ -11,7 +11,7 @@ use List::Util                 qw( any );
 use MetaCPAN::Document::Module ();
 use MetaCPAN::Types            qw( ESBool Module );
 use MetaCPAN::Types::TypeTiny qw( ArrayRef Int Maybe Num ScalarRef Stat Str );
-use MetaCPAN::Util            qw(numify_version true false);
+use MetaCPAN::Util            qw(numify_version true false to_bool);
 use Plack::MIME               ();
 use Pod::Text                 ();
 use Try::Tiny                 qw( catch try );
@@ -917,11 +917,7 @@ sub set_indexed {
             next;
         }
 
-        $mod->_set_indexed(
-            $mod->hide_from_pause( ${ $self->content }, $self->name )
-            ? false
-            : true
-        );
+        $mod->_set_indexed( to_bool( $self->name eq $mod->name ) );
     }
 
     if ( my $doc_name = $self->documentation ) {

lib/MetaCPAN/Document/Module.pm

@@ -111,31 +111,6 @@ sub _build_version_numified {
 my $bom
     = qr/(?:\x00\x00\xfe\xff|\xff\xfe\x00\x00|\xfe\xff|\xff\xfe|\xef\xbb\xbf)/;
 
-sub hide_from_pause {
-    my ( $self, $content, $file_name ) = @_;
-    return 0 if defined($file_name) && $file_name =~ m{\.pm\.PL\z};
-    my $pkg       = $self->name;
-    my $pkg_match = join q[(?:::|')], map quotemeta, split m{::}, $pkg;
-
-# This regexp is *almost* the same as $PKG_REGEXP in Module::Metadata.
-# [b] We need to allow/ignore a possible BOM since we read in binary mode.
-# Module::Metadata, for example, checks for a BOM and then sets the encoding.
-# [s] We change `\s` to `\h` because we want to verify that it's on one line.
-# [p] We replace $PKG_NAME_REGEXP with the specific package we're looking for.
-# [v] Simplify the optional whitespace/version group ($V_NUM_REGEXP).
-    return $content =~ /    # match a package declaration
-      ^                     # start of line
-       (?:\A$bom)?          # possible BOM at the start of the file [b]
-       [\h\{;]*             # intro chars on a line [s]
-      package               # the word 'package'
-      \h+                   # whitespace [s]
-      ($pkg_match)          # the package name [p]
-      (\h+ v?[0-9._]+)?     # optional version number (preceded by whitespace) [v]
-      \h*                   # optional whitesapce [s]
-      [;\{]                 # semicolon line terminator or block start
-    /mx ? 0 : 1;
-}
-
 =head2 set_associated_pod
 
 Expects an instance C<$file> of L<MetaCPAN::Document::File> as first parameter

lib/MetaCPAN/Util.pm

@@ -37,16 +37,21 @@ use Sub::Exporter -setup => {
         true
         false
         is_bool
+        to_bool
         MAX_RESULT_WINDOW
     ) ]
 };
 
 # Limit the maximum result window to 1000, really should be enough!
 use constant MAX_RESULT_WINDOW => 1000;
 
+sub true ();
 *true    = \&Cpanel::JSON::XS::true;
+sub false ();
 *false   = \&Cpanel::JSON::XS::false;
+sub is_bool ($);
 *is_bool = \&Cpanel::JSON::XS::is_bool;
+sub to_bool ($) { $_[0] ? true : false }
 
 sub root_dir {
     Cwd::abs_path( File::Spec->catdir(

t/document/file.t

@@ -227,11 +227,6 @@ END
     is( $file->abstract,
         'An object containing information about how to get access to teh Moby databases, resources, etc. from the mobycentral.config file'
     );
-    is(
-        $file->module->[0]
-            ->hide_from_pause( ${ $file->content }, $file->name ),
-        0, 'indexed'
-    );
     is( $file->documentation, 'MOBY::Config' );
     is( $file->level,         2 );
     test_attributes $file, {
@@ -306,9 +301,8 @@ END
         module  => [ { name => 'Number::Phone::NANP::ASS', version => 1.1 } ],
         content => \$content,
     );
-    is( $file->sloc,                                   8, '8 lines of code' );
-    is( $file->slop,                                   4, '4 lines of pod' );
-    is( $file->module->[0]->hide_from_pause($content), 1, 'not indexed' );
+    is( $file->sloc, 8, '8 lines of code' );
+    is( $file->slop, 4, '4 lines of pod' );
     is(
         $file->abstract,
         'AS-specific methods for Number::Phone',

t/document/module.t

@@ -5,61 +5,6 @@ use lib 't/lib';
 use MetaCPAN::Document::Module ();
 use Test::More;
 
-subtest hide_from_pause => sub {
-    foreach my $test (
-
-        # The original:
-        [ 'No::CommentNL' => "package # hide\n  No::CommentNL;" ],
-
-        # I'm not sure how PAUSE handles this one but currently we ignore it.
-        [ 'No::JustNL' => "package       \n  No::JustNL;" ],
-
-        # The good ones:
-        [ 'Pkg'        => 'package Pkg;' ],
-        [ 'Pkg::Ver'   => 'package Pkg::Ver v1.2.3;' ],
-        [ 'Pkg::Block' => 'package Pkg::Block           { our $var = 1 }' ],
-        [
-            'Pkg::VerBlock' => 'package Pkg::VerBlock  1.203 { our $var = 1 }'
-        ],
-        [ 'Pkg::SemiColons' => '; package Pkg::SemiColons; $var' ],
-        [ 'Pkg::InABlock'   => '{ package Pkg::InABlock; $var }' ],
-
-        # This doesn't work as a BOM can only appear at the start of a file.
-        #[ 'Pkg::AfterABOM'  => "\xef\xbb\xbfpackage Pkg::AfterABOM" ],
-
-        [ 'No::JustVar' => qq["\n\$package No::JustVar;\n"] ],
-
-        # This shouldn't match, but there's only so much we can do...
-        # we're not going to eval the whole file to figure it out.
-        [ 'Pkg::InsideStr' => qq["\n  package Pkg::InsideStr;\n"] ],
-
-        [ 'No::Comment'    => qq[# package No::Comment;\n] ],
-        [ 'No::Different'  => q[package No::Different::Pkg;] ],
-        [ 'No::PkgWithNum' => qq["\npackage No::PkgWithNumv2.3;\n"] ],
-        [ 'No::CrazyChars' => qq["\npackage No::CrazyChars\[0\];\n"] ],
-        )
-    {
-        my ( $name, $content ) = @$test;
-
-        subtest $name => sub {
-            my $module = MetaCPAN::Document::Module->new( name => $name );
-
-        SKIP: {
-                skip( 'Perl 5.14 needed for package block compilation', 1 )
-                    if $] < 5.014;
-                ## no critic
-                ok eval "sub { no strict; $content }", "code compiles"
-                    or diag $@;
-            }
-
-            my ($hidden) = ( $name =~ /^No::/ ? 1 : 0 );
-
-            is $module->hide_from_pause($content), $hidden,
-                "hide_from_pause is $hidden";
-        };
-    }
-};
-
 subtest set_associated_pod => sub {
     test_associated_pod( 'Squirrel', [qw( lib/Squirrel.pod )],
         'lib/Squirrel.pod' );