Merge pull request #3086 from metacpan/haarg/fix-warnings

Fix some common warnings/errors shown in the logs.

Author: haarg

lib/MetaCPAN/Web/Controller/Dist.pm

@@ -7,6 +7,9 @@ BEGIN { extends 'MetaCPAN::Web::Controller' }
 
 sub root : Chained('/') PathPart('dist') CaptureArgs(1) {
     my ( $self, $c, $dist ) = @_;
+    if ( $dist =~ /[^A-Za-z0-9_\-\.\@\+]/ ) {
+        $c->detach('/not_found');
+    }
     $c->stash( { distribution_name => $dist } );
 }
 

root/diff.tx

@@ -37,8 +37,8 @@
     </li>
     %%  }
     <li class="nav-header">Info</li>
-    <li>[% pluralize("%d insertion(s)", $diff.statistics.map(-> $f { $f.insertions }).sum()) %]</li>
-    <li>[% pluralize("%d deletion(s)", $diff.statistics.map(-> $f { $f.deletions }).sum()) %]</li>
+    <li>[% pluralize("%d insertion(s)", $diff.statistics.map(-> $f { $f.insertions }).grep(rx('^\d+$')).sum()) %]</li>
+    <li>[% pluralize("%d deletion(s)", $diff.statistics.map(-> $f { $f.deletions }).grep(rx('^\d+$')).sum()) %]</li>
     <li><div><a href="#">Top</a></div></li>
 %%  }
 %%  override content -> {
@@ -51,7 +51,7 @@
       %%  }
       <tr>
         <td>[% pluralize("%s file(s)", $diff.statistics.size()) %] changed  (This is a [% $diff.source.file ? 'file' : 'version' %] diff)</td>
-        <td><span class="minus">[% $diff.statistics.map(-> $f { $f.deletions }).sum() %]</span><span class="plus">[% $diff.statistics.map(-> $f { $f.insertions }).sum() %]</span></td>
+        <td><span class="minus">[% $diff.statistics.map(-> $f { $f.deletions }).grep(rx('^\d+$')).sum() %]</span><span class="plus">[% $diff.statistics.map(-> $f { $f.insertions }).grep(rx('^\d+$')).sum() %]</span></td>
       </tr>
     </table>
 

t/controller/release.t

@@ -11,6 +11,9 @@ test_psgi app, sub {
     ok( my $res = $cb->( GET '/dist/DOESNTEXIST' ), 'GET /dist/DOESNTEXIST' );
     is( $res->code, 404, 'code 404' );
 
+    ok( $res = $cb->( GET '/dist/$$$$' ), 'GET /dist/$$$$' );
+    is( $res->code, 404, 'code 404' );
+
     ok( $res = $cb->( GET '/release/AUTHORDOESNTEXIST/DOESNTEXIST' ),
         'GET /release/AUTHORDOESNTEXIST/DOESNTEXIST' );
     is( $res->code, 404, 'code 404' );