Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to jstransformer #96

Closed
jmatsushita opened this issue May 29, 2016 · 6 comments
Closed

Migrate to jstransformer #96

jmatsushita opened this issue May 29, 2016 · 6 comments

Comments

@jmatsushita
Copy link

jmatsushita commented May 29, 2016

Hi there,

I had slow rendering times with a site using the jade/pug engine with metalsmith-layouts.

Using metalsmith-jstransformer-layouts helped speed up the rendering time of a jade metalsmith site previously using metalsmith-layouts from 9s to 2.9s.

I've done some early work that would allow to make metalsmith-jstransformer-layouts a drop in replacement for metalsmith-layouts.

I'm not sure that jstransformer covers all the rendering engines that consolidate.js does but it does cover a large amount of them and is fast.

Maybe it would be worth considering making the default metalsmith rendering engine migrate to jstransformer?

Cheers!

Jun

@doodzik
Copy link
Contributor

doodzik commented May 29, 2016

do you have reproducible benchmarks?

@jmatsushita
Copy link
Author

I'm afraid I don't! I only tested with one project. If there was a fixture to stress metalsmith-layouts then I'd be happy to run the fork of metalsmith-jstransformer-layouts in it!

@doodzik
Copy link
Contributor

doodzik commented Jun 1, 2016

I think that the way to go here would be to make consolidate.js the default and that you can add your engine of choice as a dependency injection. if something even faster comes along we won't need to rewrite the whole library ;)

If you want you can open a PR with that change. I wouldn't be opposed to it.

@doodzik doodzik closed this as completed Jun 1, 2016
@ghost
Copy link

ghost commented Jun 1, 2016

Switching could also be an option if there are no breaking changes. If there are however, it would have to be significantly better than consolidate to justify breaking features.

@doodzik
Copy link
Contributor

doodzik commented Jun 3, 2016

@jmatsushita are you still interested in helping on adding jstransformer to this metalsmith-layouts?

further discussion is going to take place on the issue #100

@jmatsushita
Copy link
Author

Sorry @doodzik I don't have time to help on implementation. Very happy to test though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants