Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an explicit library for assertions #29

Open
lorisleiva opened this issue Apr 21, 2022 · 3 comments
Open

Use an explicit library for assertions #29

lorisleiva opened this issue Apr 21, 2022 · 3 comments

Comments

@lorisleiva
Copy link
Contributor

As discussed, this is just a reminded task to explicitly import an assertion library such as npm install assert instead of relying on polyfills to make it easier for developers to get started with libraries using beets.

@olivbau
Copy link

olivbau commented Jan 31, 2023

I'm trying to use @metaplex-foundation/mpl-token-metadata on browser (with vitejs) and I get this error.
Do you know a work around ?

image

@grabbou
Copy link

grabbou commented Feb 9, 2023

Yes, please! Please make assert a dependency, otherwise, we have to polyfill when using various packages that depend on this one!

@olivbau
Copy link

olivbau commented Feb 9, 2023

@lorisleiva
Maybe add an assert package as peer-dependency ?

blockiosaurus added a commit that referenced this issue Dec 5, 2023
Use an explicit library for assertions #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants