Fix potential issue when crashing on error

Author: arunoda

Diff for: .versions

@@ -165,8 +165,8 @@ Balancer._proxyWeb = function _proxyWeb(req, res, endpoint, cookies, retries) {
       console.error("Cluster: web proxy error: ", message);
       if(!dontSendHeaders) {
         res.writeHead(500);
+        res.end("Internal Error: Please reload.");
       }
-      res.end("Internal Error: Please reload.");
     }
   });
 };

Diff for: lib/server/balancer/utils.js

@@ -80,7 +80,7 @@ Balancer._processHereHTTP = function _processHereHTTP(req, res) {
       // Make sure we support long polling
       res.setTimeout(2 * 60 * 1000);
       Balancer.proxy.web(req, res, {target: target}, function(err) {
-        res.end();
+        // res.end();
         // Since this is long polling, error can happen even if user close the
         // session. That's why we don't print the message.
 

Diff for: lib/server/balancer/workers.js

@@ -262,7 +262,7 @@ function(test) {
 
   Balancer._proxyWeb(req, res, endpoint, cookies);
 
-  test.equal(res.end.callCount, 1);
+  test.equal(res.end.callCount, 0);
   test.equal(res.writeHead.callCount, 0);
   proxyMock.verify();
   proxyMock.restore();

Diff for: tests/server/balancer/utils.js

@@ -174,7 +174,7 @@ function(test) {
       var lastArg = web.getCall(0).args.pop();
       lastArg();
 
-      test.isTrue(res.end.calledOnce);
+      test.isFalse(res.end.calledOnce);
 
       // let's call again
       Balancer._processHereHTTP(req, res);