Start the WorkerPool in a better way

Author: arunoda

lib/server/balancer/route.js

@@ -1,7 +1,13 @@
 var Cookies = Npm.require('cookies');
 
-var workers = process.env['CLUSTER_WORKERS_COUNT'] || 0;
-workers = new WorkerPool(workers);
+var workers = null;
+
+// We need to start the worker pool after the server binded
+// This allow use to play nicely with tools like userdown
+WebApp.onListening(function() {
+  var workersCount = Balancer._getWorkersCount();
+  workers = new WorkerPool(workersCount);
+});
 
 Balancer.handleHttp = function handleHttp(req, res) {
   if(!Cluster.discovery) return processHereHTTP();
@@ -109,7 +115,7 @@ function processHereHTTP() {
 function processHereWS(req, socket, head) {
   if(process.env['CLUSTER_WORKER_ID']) return;
 
-  var worker = workers.pickWorker();
+  var worker = workers && workers.pickWorker();
   // No worker, can't proxy. So process here.
   if(!worker) return false;
 

lib/server/balancer/utils.js

@@ -1,5 +1,20 @@
 var urlParse = Npm.require('url').parse;
 var urlResolve = Npm.require('url').resolve;
+var os = Npm.require('os');
+
+Balancer._getWorkersCount = function() {
+  var workersCount = process.env['CLUSTER_WORKERS_COUNT'];
+  if(("" + workersCount).toLowerCase() === "auto") {
+    workersCount = os.cpus().length;
+  }
+
+  // We don't need to start a worker in this case
+  if(workersCount == 1) {
+    workersCount = 0;
+  }
+
+  return workersCount;
+};
 
 Balancer._buildCookie = function _buildCookie(name, service) {
   return name + "::" + service;