Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UB in hdf5_types::impl_tuple! macro #54

Closed
magnusuMET opened this issue Jan 28, 2025 · 2 comments · Fixed by #57
Closed

UB in hdf5_types::impl_tuple! macro #54

magnusuMET opened this issue Jan 28, 2025 · 2 comments · Fixed by #57

Comments

@magnusuMET
Copy link
Collaborator

Duplicate of aldanor#304, since we have not changed this line of code in the codebase
@magnusuMET
Copy link
Collaborator Author

See https://rust-lang.github.io/rfcs/3308-offset_of.html#offset_of-on-other-types for a way to use offset_of macro instead of pointer shenanigans

@RalfJung
Copy link

I'd recommend looking at https://doc.rust-lang.org/nightly/std/mem/macro.offset_of.html instead of the RFC. RFCs represent a design decision at the point in time when they got accepted; they are not kept up-to-date with later potential changes.

@magnusuMET magnusuMET mentioned this issue Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove H5Type for tuples mulimoen/hdf5-rust
2 participants
@RalfJung @magnusuMET