fix(combinator): catch and log Display Expression errors

metricq · Jan 27, 2025 · 2c47091 · 2c47091
1 parent 01e0b50
commit 2c47091
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/combinator.cpp b/src/combinator.cpp
@@ -201,7 +201,14 @@ void Combinator::on_transformer_config(const metricq::json& config)
         // Register the combined metric as a new source metric
         auto& metric = (*this)[combined_name];
 
-        metric.metadata["displayExpression"] = displayExpression(combined_expression);
+        try
+        {
+            metric.metadata["displayExpression"] = displayExpression(combined_expression);
+        }
+        catch (std::runtime_error&)
+        {
+            Log::error("Failed to create the Display Expression");
+        }
 
         if (combined_config.count("chunk_size"))
         {