From bc7c56432c1c9ef50bffad1b87c6ac8026747810 Mon Sep 17 00:00:00 2001 From: yash-metron Date: Thu, 27 Feb 2025 18:35:05 +0530 Subject: [PATCH] Fixed _format_datetime --- Packs/Doppel/Integrations/Doppel/Doppel.py | 9 +++------ Packs/Doppel/Integrations/Doppel/Doppel_test.py | 12 +++--------- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/Packs/Doppel/Integrations/Doppel/Doppel.py b/Packs/Doppel/Integrations/Doppel/Doppel.py index 1a14095bc530..8766d73c0ace 100644 --- a/Packs/Doppel/Integrations/Doppel/Doppel.py +++ b/Packs/Doppel/Integrations/Doppel/Doppel.py @@ -381,12 +381,9 @@ def format_datetime(timestamp_str): return timestamp_str # Already in ISO format except ValueError: datetime_obj = arg_to_datetime(timestamp_str) - # Convert datetime object to string - date_str = datetime_to_string(datetime_obj) - # Convert to datetime object - dt_obj = datetime.strptime(date_str, "%Y-%m-%d %H:%M:%S.%f%z") - # Convert to ISO 8601 format - iso_format_truncated = dt_obj.isoformat(timespec='seconds') + + # Convert to standard ISO 8601 format without microseconds and timezone + iso_format_truncated = datetime_obj.strftime("%Y-%m-%dT%H:%M:%S") return iso_format_truncated diff --git a/Packs/Doppel/Integrations/Doppel/Doppel_test.py b/Packs/Doppel/Integrations/Doppel/Doppel_test.py index 96877cc3db9e..f70376c55111 100644 --- a/Packs/Doppel/Integrations/Doppel/Doppel_test.py +++ b/Packs/Doppel/Integrations/Doppel/Doppel_test.py @@ -903,15 +903,9 @@ def test_format_datetime(): # Test None input assert format_datetime(None) is None - # Test non-ISO datetime - non_iso_input = "Feb 27, 2025 14:30" - expected_output = datetime.strptime("Feb 27, 2025 14:30", "%b %d, %Y %H:%M").isoformat() - assert format_datetime(non_iso_input) == expected_output - - # Test another format - non_iso_input_2 = "27-02-2025 14:30" - expected_output_2 = datetime.strptime("27-02-2025 14:30", "%d-%m-%Y %H:%M").isoformat() - assert format_datetime(non_iso_input_2) == expected_output_2 + # Test non-ISO datetime (without mocking) + assert format_datetime("Feb 27, 2025 14:30") == "2025-02-27T14:30:00" + assert format_datetime("27-02-2025 14:30") == "2025-02-27T14:30:00" # Test invalid format with pytest.raises(ValueError):