fix pipeline issues

Author: nuryagdym

phpstan-baseline.neon

@@ -12,18 +12,6 @@ parameters:
 			count: 1
 			path: src/Client/HttpClient.php
 
-		-
-			message: '#^Parameter \#3 \$subject of function str_replace expects array\<string\>\|string, array\<int\<0, max\>, float\|int\|string\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Crypt/EstV3PosCrypt.php
-
-		-
-			message: '#^Parameter \#3 \$subject of function str_replace expects array\<string\>\|string, list\<float\|int\|string\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Crypt/EstV3PosCrypt.php
-
 		-
 			message: '#^Default value of the parameter \#3 \$order \(array\{\}\) of method Mews\\Pos\\Crypt\\PosNetCrypt\:\:createHash\(\) is incompatible with type array\{amount\: int, currency\: string, id\: string\}\.$#'
 			identifier: parameter.defaultValue
@@ -156,12 +144,6 @@ parameters:
 			count: 1
 			path: src/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapper.php
 
-		-
-			message: '#^Property Mews\\Pos\\DataMapper\\ResponseDataMapper\\AbstractResponseDataMapper\:\:\$secureTypeMappings \(array\<string, ''3d''\|''3d_host''\|''3d_pay''\|''3d_pay_hosting''\|''regular''\>\) does not accept non\-empty\-array\<1\|2\|3\|string, ''3d''\|''3d_host''\|''3d_pay''\|''3d_pay_hosting''\|''regular''\>\.$#'
-			identifier: assign.propertyType
-			count: 1
-			path: src/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapper.php
-
 		-
 			message: '#^Method Mews\\Pos\\Factory\\PosFactory\:\:createPosGateway\(\) should return Mews\\Pos\\PosInterface but returns object\.$#'
 			identifier: return.type

src/Crypt/AbstractCrypt.php

@@ -96,7 +96,7 @@ protected function buildHashString(array $data, array $paramNames, string $separ
         $paramsVal = \implode($separator, $this->buildHashData($data, $paramNames));
 
         if (null !== $storeKey) {
-            $paramsVal = $this->concatenateHashKey($storeKey, $paramsVal);
+            return $this->concatenateHashKey($storeKey, $paramsVal);
         }
 
         return $paramsVal;

src/DataMapper/RequestDataMapper/AbstractRequestDataMapper.php

@@ -18,8 +18,11 @@
 abstract class AbstractRequestDataMapper implements RequestDataMapperInterface
 {
     protected EventDispatcherInterface $eventDispatcher;
+
     protected RequestValueMapperInterface $valueMapper;
+
     protected RequestValueFormatterInterface $valueFormatter;
+
     protected CryptInterface $crypt;
 
     protected bool $testMode = false;

src/DataMapper/RequestValueFormatter/ToslaPosRequestValueFormatter.php

@@ -55,6 +55,7 @@ public function formatDateTime(\DateTimeInterface $dateTime, string $fieldName =
         if ('timeSpan' === $fieldName) {
             return $dateTime->format('YmdHis');
         }
+
         if ('transactionDate' === $fieldName) {
             return $dateTime->format('Ymd');
         }

src/DataMapper/RequestValueMapper/AbstractRequestValueMapper.php

@@ -86,7 +86,7 @@ public function getSecureTypeMappings(): array
      */
     public function mapSecureType(string $paymentModel): string
     {
-        if (0 === count($this->secureTypeMappings)) {
+        if ([] === $this->secureTypeMappings) {
             throw new \LogicException('Security type mappings are not supported.');
         }
 
@@ -122,7 +122,7 @@ public function getRecurringOrderFrequencyMappings(): array
      */
     public function mapRecurringFrequency(string $period): string
     {
-        if (0 === count($this->recurringOrderFrequencyMappings)) {
+        if ([] === $this->recurringOrderFrequencyMappings) {
             throw new \LogicException('Recurring frequency mappings are not supported.');
         }
 
@@ -134,7 +134,7 @@ public function mapRecurringFrequency(string $period): string
      */
     public function mapLang(string $lang): string
     {
-        if (0 === count($this->langMappings)) {
+        if ([] === $this->langMappings) {
             throw new \LogicException('Language mappings are not supported.');
         }
 
@@ -162,7 +162,7 @@ public function getCardTypeMappings(): array
      */
     public function mapCardType(string $cardType): string
     {
-        if (0 === count($this->cardTypeMappings)) {
+        if ([] === $this->cardTypeMappings) {
             throw new \LogicException('Card type mappings are not supported.');
         }
 

src/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapper.php

@@ -517,6 +517,7 @@ private function mapSingleOrderHistoryTransaction(array $rawTx): array
             if (null !== $transTime) {
                 $defaultResponse['transaction_time'] = $this->valueFormatter->formatDateTime($transTime, $txType);
             }
+
             $defaultResponse['capture_time']     = null !== $rawTx['AuthDate'] ? $this->valueFormatter->formatDateTime($rawTx['AuthDate'], $txType) : null;
             $amount                              = $rawTx['AuthAmount'];
             $defaultResponse['capture_amount']   = null !== $amount ? $this->valueFormatter->formatAmount($amount, $txType) : null;

src/DataMapper/ResponseValueFormatter/AbstractResponseValueFormatter.php

@@ -1,7 +1,9 @@
 <?php
+
 /**
  * @license MIT
  */
+
 namespace Mews\Pos\DataMapper\ResponseValueFormatter;
 
 class AbstractResponseValueFormatter implements ResponseValueFormatterInterface

src/DataMapper/ResponseValueFormatter/BasicResponseValueFormatter.php

@@ -1,7 +1,9 @@
 <?php
+
 /**
  * @license MIT
  */
+
 namespace Mews\Pos\DataMapper\ResponseValueFormatter;
 
 class BasicResponseValueFormatter extends AbstractResponseValueFormatter

src/DataMapper/ResponseValueFormatter/BoaPosResponseValueFormatter.php

@@ -1,7 +1,9 @@
 <?php
+
 /**
  * @license MIT
  */
+
 namespace Mews\Pos\DataMapper\ResponseValueFormatter;
 
 use Mews\Pos\PosInterface;

src/DataMapper/ResponseValueFormatter/EstPosResponseValueFormatter.php

@@ -1,7 +1,9 @@
 <?php
+
 /**
  * @license MIT
  */
+
 namespace Mews\Pos\DataMapper\ResponseValueFormatter;
 
 use Mews\Pos\PosInterface;