Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache tag rule for plugin managers #824

Open
Berdir opened this issue Feb 1, 2025 · 0 comments
Open

Remove cache tag rule for plugin managers #824

Berdir opened this issue Feb 1, 2025 · 0 comments

Comments

@Berdir
Copy link

Berdir commented Feb 1, 2025

Saw this in the entity_embed project.

  Line   src/EntityEmbedDisplay/EntityEmbedDisplayManager.php                  
 ------ ---------------------------------------------------------------------- 
  33     config:entity_view_mode_list cache tag might be unclear and does not  
         contain the cache key in it.       

This is very opinionated and IMHO not correct.

Cache tags in general in plugin managers are somewhat discouraged for performance reasons and explicit invalidation is recommended. but there's no requirement for them to include the cache key or be "clear".

Cache tags in plugin managers and other frequently used things should only be used if there a unknown amount of cache variations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant