1268 dm text highlighting #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed inline styles from certain code snippets and replaced with the language-text class to apply dark mode styling. Also replaced certain ic-links in markdown with a tag so it inherits the GatsbyLink from the coretemplate to prevent flashing of site
updated component testing buttons to copy the theme of the site, and therefore display updated monochrome variants. Also removed oppositeTheme from the context as it was not used after this re #1257
|
View your branch deployment here: https://mi6.github.io/ic-design-system-githubpages/branches/1268-dm-text-highlighting |
GCHQ-Developer-299
approved these changes
Dec 19, 2024
GCHQ-Developer-530
approved these changes
Dec 19, 2024
src/content/structured/accessibility/testing/automated-testing-limitation.mdx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
<code>tags, swapping it for thelanguage-textclass which would apply dark mode styling in line with other code snippets. Certain text highlighting not displaying correctly in dark mode #1268<a>tags so that they utilised GatsbyLink through the WrappedLink component. Check all links on V3 Guidance Site work and don't cause flicker ic-ui-kit#2893oppositeThemefrom the ThemeContext as it was no longer being used after swapping the theme.Checklist