Skip to content

Commit

Permalink
fix(react): toggle button displays correct high contrast colours when…
Browse files Browse the repository at this point in the history
… checked and unchecked

toggle button in loading variant displays correct high contrast colours when checked and unchecked.
failure thresholds in tests have been adjusted when creating new visual regression images for loading variant.
  • Loading branch information
srt544 committed Feb 3, 2025
1 parent 98ec970 commit 5335c45
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ describe("IcToggleButton visual regression and a11y tests", () => {
cy.checkA11yWithWait(undefined, undefined, TOGGLE_BUTTON_AXE_OPTIONS);
cy.compareSnapshot({
name: "tooltip-placement-right",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.032),
});

cy.findShadowEl(IC_TOGGLE_BUTTON_SELECTOR, "ic-button")
Expand All @@ -306,7 +306,7 @@ describe("IcToggleButton visual regression and a11y tests", () => {
cy.checkA11yWithWait(undefined, undefined, TOGGLE_BUTTON_AXE_OPTIONS);
cy.compareSnapshot({
name: "tooltip-placement-top",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.032),
});

cy.findShadowEl(IC_TOGGLE_BUTTON_SELECTOR, "ic-button")
Expand All @@ -318,7 +318,7 @@ describe("IcToggleButton visual regression and a11y tests", () => {
cy.checkA11yWithWait(undefined, undefined, TOGGLE_BUTTON_AXE_OPTIONS);
cy.compareSnapshot({
name: "tooltip-placement-left",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.032),
});
});

Expand All @@ -329,7 +329,7 @@ describe("IcToggleButton visual regression and a11y tests", () => {
cy.checkA11yWithWait(undefined, undefined, TOGGLE_BUTTON_AXE_OPTIONS);
cy.compareSnapshot({
name: "light-theme-monochrome",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.029),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.037),
});
});

Expand All @@ -340,7 +340,7 @@ describe("IcToggleButton visual regression and a11y tests", () => {
cy.checkA11yWithWait(undefined, undefined, TOGGLE_BUTTON_AXE_OPTIONS);
cy.compareSnapshot({
name: "dark-theme-monochrome",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.029),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.033),
});
});
});
Expand Down Expand Up @@ -412,7 +412,7 @@ describe("IcToggleButton visual regression tests in high contrast mode", () => {

cy.compareSnapshot({
name: "loading-high-contrast",
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.02),
testThreshold: setThresholdBasedOnEnv(DEFAULT_TEST_THRESHOLD + 0.01),
});
});

Expand Down

0 comments on commit 5335c45

Please sign in to comment.