Merge pull request #3029 from mi6/v3-github-action-fix-failing-tests

V3 GitHub action fix failing tests

.github/workflows/ic-ui-kit-branches.yml

@@ -137,42 +137,6 @@ jobs:
         if: ${{ needs.check-updates.outputs.canary == 'true' }}
         run: npm run test-e2e:canary
 
-  ic-ui-kit-visual-tests:
-    needs: ["check-updates"]
-    name: "Visual regression tests"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
-
-      - name: Setup node
-        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 #4.0.2
-        with:
-          node-version: 20
-
-      - name: Cache dependencies
-        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 #v4.0.2
-        with:
-          path: |
-            packages/*/node_modules
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node
-
-      - name: Install dependencies
-        run: |
-          google-chrome --version
-          npm ci
-          npm run bootstrap -- -- --ci
-
-      - name: Core visual regression tests
-        if: ${{ needs.check-updates.outputs.core == 'true' }}
-        run: npm run test-visual:ci
-
-      - name: Canary visual regression tests
-        if: ${{ needs.check-updates.outputs.canary == 'true' }}
-        run: npm run test-visual:ci:canary
-
   ic-ui-kit-cypress-tests:
     needs: [check-updates]
     name: "Cypress tests"
@@ -299,7 +263,6 @@ jobs:
       [
         ic-ui-kit-static-analysis-tests,
         ic-ui-kit-e2e-tests,
-        ic-ui-kit-visual-tests,
         check-updates,
         ic-ui-kit-cypress-tests,
       ]

.github/workflows/ic-ui-kit-develop.yml

@@ -113,35 +113,6 @@ jobs:
         if: ${{ needs.check-updates.outputs.canary == 'true' }}
         run: npm run test-e2e:canary
 
-  ic-ui-kit-visual-tests:
-    needs: [check-updates]
-    name: "Visual regression tests"
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
-      - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 #4.0.2
-        with:
-          node-version: 20
-      - uses: browser-actions/setup-chrome@97349de5c98094d4fc9412f31c524d7697115ad8 #v1.5.0
-      - name: Install dependencies
-        run: |
-          google-chrome --version
-          npm ci
-          npm run bootstrap -- -- --ci
-
-      - name: Core visual regression tests
-        if: ${{ needs.check-updates.outputs.core == 'true' }}
-        run: npm run test-visual:ci
-
-      - name: Canary visual regression tests
-        if: ${{ needs.check-updates.outputs.canary == 'true' }}
-        run: npm run test-visual:ci:canary
-
-      - name: Cypress performance tests
-        if: ${{ needs.check-updates.outputs.core == 'true' }}
-        id: core_cypress_performance_tests
-        run: npm run test-cypress-perf:ci
-
   ic-ui-kit-cypress-tests:
     needs: [check-updates]
     name: "Cypress tests"
@@ -168,12 +139,16 @@ jobs:
         id: canary_cypress_tests
         run: npm run test-cypress:ci:canary
 
+      - name: Cypress performance tests
+        if: ${{ needs.check-updates.outputs.core == 'true' }}
+        id: core_cypress_performance_tests
+        run: npm run test-cypress-perf:ci
+
   ic-ui-kit-deploy-core:
     needs:
       [
         ic-ui-kit-static-analysis-tests,
         ic-ui-kit-e2e-tests,
-        ic-ui-kit-visual-tests,
         check-updates,
         ic-ui-kit-cypress-tests,
       ]

.github/workflows/ic-ui-kit-main.yml

@@ -108,31 +108,6 @@ jobs:
         if: ${{ needs.check-updates.outputs.canary == 'true' }}
         run: npm run test-e2e:canary
 
-  ic-ui-kit-visual-tests:
-    needs: ["check-updates"]
-    name: "Visual regression tests"
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
-      - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 #4.0.2
-        with:
-          node-version: 20
-      - uses: browser-actions/setup-chrome@97349de5c98094d4fc9412f31c524d7697115ad8 #v1.5.0
-
-      - name: Install dependencies
-        run: |
-          google-chrome --version
-          npm ci
-          npm run bootstrap -- -- --ci
-
-      - name: Core visual regression tests
-        if: ${{ needs.check-updates.outputs.core == 'true' }}
-        run: npm run test-visual:ci
-
-      - name: Canary visual regression tests
-        if: ${{ needs.check-updates.outputs.canary == 'true' }}
-        run: npm run test-visual:ci:canary
-
   ic-ui-kit-cypress-tests:
     needs: [check-updates]
     name: "Cypress tests"
@@ -169,7 +144,6 @@ jobs:
       [
         ic-ui-kit-static-analysis-tests,
         ic-ui-kit-e2e-tests,
-        ic-ui-kit-visual-tests,
         ic-ui-kit-cypress-tests,
       ]
     name: "Publish production packages"

.github/workflows/ic-ui-kit-v3.yml

@@ -108,31 +108,6 @@ jobs:
         if: ${{ needs.check-updates.outputs.canary == 'true' }}
         run: npm run test-e2e:canary
 
-  ic-ui-kit-visual-tests:
-    needs: ["check-updates"]
-    name: "Visual regression tests"
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
-      - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 #4.0.2
-        with:
-          node-version: 20
-      - uses: browser-actions/setup-chrome@97349de5c98094d4fc9412f31c524d7697115ad8 #v1.5.0
-
-      - name: Install dependencies
-        run: |
-          google-chrome --version
-          npm ci
-          npm run bootstrap -- -- --ci
-
-      - name: Core visual regression tests
-        if: ${{ needs.check-updates.outputs.core == 'true' }}
-        run: npm run test-visual:ci
-
-      - name: Canary visual regression tests
-        if: ${{ needs.check-updates.outputs.canary == 'true' }}
-        run: npm run test-visual:ci:canary
-
   ic-ui-kit-cypress-tests:
     needs: [check-updates]
     name: "Cypress tests"
@@ -164,7 +139,6 @@ jobs:
       [
         ic-ui-kit-static-analysis-tests,
         ic-ui-kit-e2e-tests,
-        ic-ui-kit-visual-tests,
         ic-ui-kit-cypress-tests,
       ]
     name: "Publish v3 packages"

.gitignore

@@ -3,14 +3,10 @@ dist-perf/
 build/
 www/
 
-packages/web-components/.loki/current
-packages/web-components/.loki/difference
 packages/web-components/docs.d.ts
 packages/react/css/
 packages/docs/docs.d.ts
 
-packages/canary-web-components/.loki/current
-packages/canary-web-components/.loki/difference
 packages/canary-react/css/
 
 packages/web-components/storybook-static

package.json

@@ -26,16 +26,6 @@
     "build-storybook:nextjs": "lerna run build-storybook --scope @ukic/nextjs",
     "cypress:install:react": "./packages/react/node_modules/cypress/bin/cypress install",
     "cypress:install:canary-react": "./packages/canary-react/node_modules/cypress/bin/cypress install",
-    "test-visual:all": "npm run test-visual && npm run test-visual:canary",
-    "test-visual:ci:all": "npm run test-visual:ci && npm run test-visual:ci:canary",
-    "test-visual": "npm run build && npm run build-storybook:web-components && lerna run test-visual --scope @ukic/web-components --stream",
-    "test-visual:canary": "npm run build:canary && npm run build-storybook:canary-web-components && lerna run test-visual --scope  @ukic/canary-web-components --stream",
-    "test-visual:ci": "npm run build && npm run build-storybook:web-components && lerna run test-visual:ci --stream",
-    "test-visual:ci:canary": "npm run build:all && npm run build-storybook:canary-web-components && lerna run test-visual:ci:canary --stream",
-    "test-visual:update": "lerna run test-visual:update --scope=@ukic/web-components --stream",
-    "test-visual:update-ci": "npm run build && lerna run test-visual:update --scope=@ukic/web-components --stream",
-    "test-visual:update:canary": "lerna run test-visual:update --scope @ukic/canary-web-components --stream",
-    "test-visual:update-ci:canary": "npm run build:all && lerna run test-visual:update:canary --stream",
     "test-cypress": "lerna run cypress --scope=@ukic/react --stream",
     "test-cypress:headless": "lerna run cypress:ci --scope=@ukic/react --stream",
     "test-cypress:ci": "npm run build && npm run test-cypress:headless",