-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ic-side-navigation] sideNavExpanded event should use @Event so it appears in docs #1348
Comments
GCHQ-Developer-530
added a commit
that referenced
this issue
Jan 4, 2024
…event decorator Update sideNavExpanded and topNavResized to use event decorator and appear in docs . #1348
21 tasks
GCHQ-Developer-530
added a commit
that referenced
this issue
Jan 8, 2024
…event decorator Update sideNavExpanded and topNavResized to use event decorator and appear in docs . #1348
jd239
pushed a commit
that referenced
this issue
Jan 15, 2024
…event decorator Update sideNavExpanded and topNavResized to use event decorator and appear in docs . #1348
jd239
pushed a commit
that referenced
this issue
Jan 15, 2024
…event decorator Update sideNavExpanded and topNavResized to use event decorator and appear in docs . #1348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of the bug
At the moment, the sideNavExpanded event is added like this:
But this means it doesn't show up in the docs on our website, and it also isn't consistent with other components.
We should look into rewriting it so that we have
@Event() sideNavExpanded
and emit the event like we do elsewhere:If a rewrite like this isn't possible, we should look into how to manually get the event in its current state into docs.
The only other component that creates an event like this is top nav for topNavResized. This should be updated too.
🧐 Expected behaviour
sideNavExpanded event should show up in docs.
The text was updated successfully, but these errors were encountered: