Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Try CSSlint from eslint #2829

Closed
evenstensberg opened this issue Nov 26, 2024 · 3 comments
Closed

Suggestion: Try CSSlint from eslint #2829

evenstensberg opened this issue Nov 26, 2024 · 3 comments
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before

Comments

@evenstensberg
Copy link
Contributor

evenstensberg commented Nov 26, 2024

Summary

Even though there’s an implemented css linter, consider either replacing stylelint or add css linting to the current eslint configuration.

The issue is not really needed so feel free to close if not wanted. Good first issue.

💬 Description

See above

💰 User value

Coherent tooling and less dotfiles.

📚 User Stories

As an ICDS user: linting css
I need to have concurrent linting
So that we have less dependencies

📝 Acceptance Criteria

Given eslint
When linting css
Then I should be happy

✏ Designs

N/A

## 🧾 Guidance

https://www.npmjs.com/package/@eslint/css

Additional info

N/A

@evenstensberg
Copy link
Contributor Author

You will also need to:

  • bump the eslint dependency
  • change from cjs to esm config file

@evenstensberg
Copy link
Contributor Author

@GCHQ-Developer-530 I think this is a good thing to try at the ic-ui-test repo, no?

I’ve made a few PRs there but I guess it’s not a priority.

@GCHQ-Developer-530
Copy link
Contributor

Sorry we must've missed those! We've approved one already and we're taking a look at the other PR 👍

I agree though, this would be good to test in the ic-ui-kit-test repo first and then move over to the main ic-ui-kit repo if that all goes smoothly.

@GCHQ-Developer-299 GCHQ-Developer-299 added this to the Future Release milestone Dec 19, 2024
@GCHQ-Developer-299 GCHQ-Developer-299 added the good first issue A good starter issue if you haven't contributed to the ICDS before label Dec 19, 2024
@github-project-automation github-project-automation bot moved this from In Refinement to Done in Intelligence Community Design System Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Projects
Development

No branches or pull requests

3 participants