New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismissable Chip: Customisable tooltip text #2839

Closed

GCHQ-Developer-299 opened this issue Nov 28, 2024 · 0 comments

Assignees

Milestone

Contributor

GCHQ-Developer-299 commented Nov 28, 2024

Summary

Suggestion from an internal user to allow customisation of the tooltip text on dismissible chips.

💬 Description

A new optional prop for Dismissible Chip that would pass tooltip text down into the dismiss button's tooltip.

💰 Use value

The user gave the scenario of using the chips to display members of staff involved in an event and one of their leads was wondering if they can change the word 'Dismiss' in this context. In this situation "remove" might make more semantic sense.

github-project-automation bot added this to Intelligence Community Design System

lz405 added a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

7bff4f7

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

lz405 mentioned this issue

feat(web-components): [ic-chip] add prop to customise tooltip text #2884

Merged

26 tasks

lz405 added a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

35c7e8b

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

GCHQ-Developer-530 pushed a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

b6c5132

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

MI6-255 added this to the PI 10 V3 milestone

MI6-255 moved this to Dev In Progress in Intelligence Community Design System

MI6-255 moved this from Dev In Progress to In Review in Intelligence Community Design System

GCHQ-Developer-530 pushed a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

fea7eb3

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

GCHQ-Developer-530 added a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

GCHQ-Developer-530 added a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

05f7f87

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

GCHQ-Developer-530 added a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

bd5987f

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

gd2910 pushed a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

3c527ab

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

gd2910 pushed a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

0968d51

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

GCHQ-Developer-112 assigned gd2910 and lz405

GCHQ-Developer-112 closed this as completed

github-project-automation bot moved this from In Review to Done in Intelligence Community Design System

jk15926 pushed a commit to ec1467/ic-ui-kit that referenced this issue


          feat(web-components): add prop to customise tooltip text

5aa56ef

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat mi6#2839

jk15926 pushed a commit to ec1467/ic-ui-kit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

0f34046

Add prop to customise tooltip label for chip. Add Cypress test and stories

. mi6#2839

GCHQ-Developer-112 pushed a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

8849e18

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

GCHQ-Developer-112 pushed a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

a50d322

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(web-components): add prop to customise tooltip text

645c2d5

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat mi6#2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

e148a37

Add prop to customise tooltip label for chip. Add Cypress test and stories

. mi6#2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(web-components): add prop to customise tooltip text

837f114

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat mi6#2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

e0f6095

Add prop to customise tooltip label for chip. Add Cypress test and stories

. mi6#2839

GCHQ-Developer-741 pushed a commit that referenced this issue


          feat(web-components): add prop to customise tooltip text

1a9b259

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat #2839

GCHQ-Developer-741 pushed a commit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

9acae4f

Add prop to customise tooltip label for chip. Add Cypress test and stories

. #2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(web-components): add prop to customise tooltip text

d86d82c

add a new dismissLabel prop which allows the user to change the text of the label on the dismiss
button

feat mi6#2839

am26090 pushed a commit to am26090/ic-ui-kit that referenced this issue


          feat(react): add prop to customise tooltip label for chip

41387bb

Add prop to customise tooltip label for chip. Add Cypress test and stories

. mi6#2839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment