Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IcDialog: Display issues at >200% Zoom #2868

Open
GCHQ-Developer-299 opened this issue Dec 5, 2024 · 0 comments
Open

IcDialog: Display issues at >200% Zoom #2868

GCHQ-Developer-299 opened this issue Dec 5, 2024 · 0 comments
Assignees
Milestone

Comments

@GCHQ-Developer-299
Copy link
Contributor

Summary of the bug

Reported by an internal user - when browser zoom is above 200% (and crucially at the 400% specified by WCAG Criterion 1.4.10) IcDialogs display incorrectly.

🪜 How to reproduce

Issue can be seen on Guidance Site dialog examples and Dialog Storybook

Once dialog is open, zoom the page above 200% and see that it spills above the viewport. The dialog title is not visible.

📸 Screenshots or code

Screenshot 2024-12-05 at 11 12 32

🧐 Expected behaviour

For the full dialog to be visible (potentially through internal scrolling?)

@MI6-255 MI6-255 added this to the PI 10 V3 milestone Dec 18, 2024
@MI6-255 MI6-255 moved this from In Refinement to Ready for dev in Intelligence Community Design System Jan 16, 2025
@MI6-255 MI6-255 modified the milestones: PI 10 V3, PI 11 V3 Jan 28, 2025
@gd2910 gd2910 self-assigned this Feb 12, 2025
@gd2910 gd2910 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Feb 12, 2025
@gd2910 gd2910 removed their assignment Feb 17, 2025
@gd2910 gd2910 moved this from Dev In Progress to Ready for dev in Intelligence Community Design System Feb 17, 2025
@GCHQ-Developer-847 GCHQ-Developer-847 self-assigned this Feb 24, 2025
@GCHQ-Developer-847 GCHQ-Developer-847 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Feb 24, 2025
GCHQ-Developer-847 added a commit that referenced this issue Feb 25, 2025
…it easier to scroll

Make scrollbar appear on content area on dialog when content overflows to make it easier to scroll
through the content. Hide horizontal scrollbar to prevent any scrolling in both directions.

.#2868
GCHQ-Developer-847 added a commit that referenced this issue Feb 26, 2025
…it easier to scroll

Make scrollbar appear on content area on dialog when content overflows to make it easier to scroll
through the content.

.#2868
GCHQ-Developer-847 added a commit that referenced this issue Feb 26, 2025
…it easier to scroll

Make scrollbar appear on content area on dialog when content overflows to make it easier to scroll
through the content.

.#2868
GCHQ-Developer-847 added a commit that referenced this issue Feb 26, 2025
…it easier to scroll

Make scrollbar appear on content area on dialog when content overflows to make it easier to scroll
through the content.

.#2868
GCHQ-Developer-847 added a commit that referenced this issue Feb 26, 2025
…it easier to scroll

Make scrollbar appear on content area on dialog when content overflows to make it easier to scroll
through the content.

.#2868
GCHQ-Developer-847 added a commit that referenced this issue Feb 26, 2025
Update dialog visual test screenshots to cover scrollbar being added onto content area.

.#2868
@GCHQ-Developer-847 GCHQ-Developer-847 moved this from Dev In Progress to In Review in Intelligence Community Design System Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

4 participants