Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser features not matching our dark mode #2869

Closed
GCHQ-Developer-741 opened this issue Dec 5, 2024 · 0 comments · Fixed by #3106 or mi6/ic-design-system#1334
Closed

Browser features not matching our dark mode #2869

GCHQ-Developer-741 opened this issue Dec 5, 2024 · 0 comments · Fixed by #3106 or mi6/ic-design-system#1334
Assignees
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Milestone

Comments

@GCHQ-Developer-741
Copy link
Contributor

GCHQ-Developer-741 commented Dec 5, 2024

Summary of the bug

Some browser specific features (such as scroll bars on certain elements) still have a light scroll bar when the system settings are light, even when a dark theme is being applied through ic-theme.

📸 Screenshots or code

In this image, the tree-view's scroll bar is light, whereas the site one is dark
image

🧐 Expected behaviour

When setting our dark mode, browser features should appear in dark mode too.

Additional info

Can potentially be solved by adding a color-scheme property to our .ic-theme-dark class (https://www.amitmerchant.com/darkmode-aware-scrollbars-using-css/)

@GCHQ-Developer-299 GCHQ-Developer-299 added this to the PI 10 V3 milestone Jan 10, 2025
@GCHQ-Developer-299 GCHQ-Developer-299 added the good first issue A good starter issue if you haven't contributed to the ICDS before label Jan 10, 2025
@MI6-255 MI6-255 moved this from In Refinement to Ready for dev in Intelligence Community Design System Jan 23, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 self-assigned this Jan 28, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Jan 28, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from Dev In Progress to In Review in Intelligence Community Design System Jan 28, 2025
@srt544 srt544 self-assigned this Jan 28, 2025
@MI6-255 MI6-255 modified the milestones: PI 10 V3, PI 11 V3 Jan 28, 2025
@srt544 srt544 removed their assignment Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Projects
4 participants