Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether React 19 will be compatible with ICDS React components #2891

Closed
GCHQ-Developer-112 opened this issue Dec 11, 2024 · 5 comments
Assignees
Labels
spike This issue needs to be researched and explored before determining a course of action
Milestone

Comments

@GCHQ-Developer-112
Copy link
Contributor

Summary

Ensure that React 19 is compatible with ICDS React components. Check for breaking changes and any potential issues that arise if React 19 is used with ICDS React components

@GCHQ-Developer-112 GCHQ-Developer-112 added the spike This issue needs to be researched and explored before determining a course of action label Dec 11, 2024
@GCHQ-Developer-112 GCHQ-Developer-112 added this to the PI 10 V3 milestone Dec 11, 2024
@evenstensberg
Copy link
Contributor

I think the best way to do this is to just update to v19 and then see if any regression happens.

@evenstensberg
Copy link
Contributor

FYI I just ran ncu -u (npm-check-updates) and it seems some packages havent bumped the react dependencies yet. So that means you probably need to wait sometime to be able to smoothly update the deps that again rely on the correct react version.

While doing this, you should update all dependencies (in both monorepo and root package level).

@ad9242
Copy link
Contributor

ad9242 commented Jan 13, 2025

duplicate here: #2939

@evenstensberg
Copy link
Contributor

Summary

I've tried updating deps again ncu -u in the react package. If you run:

  1. ncu -u
  2. npm i --legacy-peer-deps

The installations doesnt cause an error, but there are two problems:

1 (cypress doesnt support react v19 yet)

Screenshot 2025-01-13 at 19 31 14

2

There's a change in how you declare refs in v18 -> v19 (https://react.dev/blog/2024/12/05/react-19#ref-as-a-prop)

@GCHQ-Developer-530 GCHQ-Developer-530 self-assigned this Jan 24, 2025
@GCHQ-Developer-530 GCHQ-Developer-530 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Jan 24, 2025
@MI6-255 MI6-255 modified the milestones: PI 10 V3, PI 11 V3 Jan 28, 2025
This was referenced Feb 11, 2025
@GCHQ-Developer-530 GCHQ-Developer-530 moved this from Dev In Progress to Done in Intelligence Community Design System Feb 12, 2025
@GCHQ-Developer-530
Copy link
Contributor

Closed - remaining work will be done in #3158 and remaining Storybook work done after #3135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike This issue needs to be researched and explored before determining a course of action
Projects
Development

No branches or pull requests

5 participants