Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-top-navigation] Screen reader hint causes massive scrollable blank area to right of page when using RTL language #2906

Open
irl opened this issue Dec 16, 2024 · 1 comment

Comments

@irl
Copy link
Contributor

irl commented Dec 16, 2024

Summary of the bug

This is basically the same issue as #2905 except affecting the ic-top-navigation component.

The offending element is #navigation-landmark-button-text.

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Set dir="rtl" on <html>
  2. Add an ic-top-navigation
  3. Reduce the window size until the "Menu" button appears
  4. Observe a blank space appear when you scroll to the left

🖥 📱 Device

  • Type: desktop
  • Device: mac os
  • Browser version: Firefox 133

🧐 Expected behaviour

The blank space should not appear.

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given Set dir="rtl" on <html>, window size is below breakpoint for Menu button to appear
When ic-top-navigation is used
Then no blank space appears to the left

Additional info

As with #2905, this can be fixed with the :dir selector, swapping the left: for right:.

irl added a commit to irl/ic-ui-kit that referenced this issue Dec 20, 2024
…L languages

This change also standardises on using -9999px from the start of the page as the
offscreen position to make it easier to locate occurrences of this pattern with
search.

Closes: mi6#2906
@GCHQ-Developer-299 GCHQ-Developer-299 added this to the Future Release milestone Jan 15, 2025
@GCHQ-Developer-299
Copy link
Contributor

Note: pushed to future release as we don't official support RTL languages - however, if external contributor addresses issue beforehand, that's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Refinement
Development

No branches or pull requests

3 participants