Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-date-input] browser auto filled date has incorrect background colour in dark mode #2915

Closed
GCHQ-Developer-530 opened this issue Dec 17, 2024 · 0 comments
Assignees
Milestone

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary of the bug

When date input has theme="dark", and you select the browser input suggestion, the suggestion is still accepted correctly but it shows a white background rather than one that matches the date input, so it looks odd.

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to date input in dark mode
  2. Click on a browser suggestion
  3. See the error

📸 Screenshots or code

browser-input-dm-date-input

🖥 📱 Device

  • Device: Macbook
  • Browser version: Chrome

🧐 Expected behaviour

The background of the suggestion should be transparent, or at least --ic-color-background-primary so it picks up on the correct light/dark colour

Additional info

I think it's a problem with this line in the css:

input:-webkit-autofill {
box-shadow: 0 0 0 var(--ic-space-sm) var(--ic-architectural-white) inset;
}

@GCHQ-Developer-530 GCHQ-Developer-530 self-assigned this Dec 17, 2024
GCHQ-Developer-530 added a commit that referenced this issue Dec 17, 2024
…nput dark mode

Update webkit autofill colours for date input dark mode so that it appears correctly after a browser
suggestion

. #2915
@GCHQ-Developer-530 GCHQ-Developer-530 added this to the PI 10 V3 milestone Dec 17, 2024
GCHQ-Developer-530 added a commit that referenced this issue Dec 18, 2024
…nput dark mode

Update webkit autofill colours for date input dark mode so that it appears correctly after a browser
suggestion

. #2915
GCHQ-Developer-741 pushed a commit that referenced this issue Jan 8, 2025
…nput dark mode

Update webkit autofill colours for date input dark mode so that it appears correctly after a browser
suggestion

. #2915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant