Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal issue 2946 - Ic Dialog Controls are Displayed Regardless of Buttons Prop #2940

Closed
ticket-sync bot opened this issue Dec 19, 2024 · 3 comments
Closed

Internal issue 2946 - Ic Dialog Controls are Displayed Regardless of Buttons Prop #2940

ticket-sync bot opened this issue Dec 19, 2024 · 3 comments
Assignees
@srt544
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Milestone
PI 11 V3

Comments

@ticket-sync
Copy link

ticket-sync bot commented Dec 19, 2024 •
edited by ad9242
Loading

For the Ic Dialog component, the {{buttons}} prop has a description saying

If set to `false`, dialog controls will not be displayed overriding buttonProps or slotted dialog controls.

However, if slotted dialog controls are provided and the buttons prop has a value of false, these slotted dialog controls are still shown.

This is demonstrated in this StackBlitz: [https://stackblitz.com/edit/7itcua7o?file=src%2Fapp.tsx]
@ticket-sync ticket-sync bot changed the title Internal issue 2946 Internal issue 2946 - Ic Dialog Controls are Displayed Regardless of Buttons Prop Jan 13, 2025
@ad9242
Copy link
Contributor

ad9242 commented Jan 13, 2025

Whilst it does not match the documented behavior, there is a workaround of not putting any content in the slot

@GCHQ-Developer-299
Copy link
Contributor

Proposal: update comment on 'buttons' prop to clarify that it only removes the default buttons. Remove mention of 'slotted dialog controls'

@GCHQ-Developer-299 GCHQ-Developer-299 added this to the PI 11 V3 milestone Feb 7, 2025
@GCHQ-Developer-299 GCHQ-Developer-299 added the good first issue A good starter issue if you haven't contributed to the ICDS before label Feb 7, 2025
@MI6-255 MI6-255 moved this from In Refinement to Ready for dev in Intelligence Community Design System Feb 13, 2025
@srt544 srt544 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Feb 18, 2025
@srt544 srt544 self-assigned this Feb 18, 2025
@srt544 srt544 moved this from Dev In Progress to In Review in Intelligence Community Design System Feb 18, 2025
@srt544
Copy link
Contributor

srt544 commented Feb 20, 2025

fix has been merged

@srt544 srt544 closed this as completed Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srt544 srt544

Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Projects
Intelligence Community Design System
Status: Done
Milestone
PI 11 V3
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/2940-internal-issue-2946---ic-dialog-controls-are-displayed-regardless-of-buttons-prop mi6/ic-ui-kit
3 participants
@GCHQ-Developer-299 @ad9242 @srt544