Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - core web-components package has to be installed along with React package #2974

Closed
ad9242 opened this issue Jan 6, 2025 · 0 comments
Closed
Assignees
Milestone

Comments

@ad9242
Copy link
Contributor

ad9242 commented Jan 6, 2025

Summary of the bug

In v2, it was possible to just install the React package. However, in v3, it seems that you also need to install the web-components package as a dependency in order for the components to render correctly

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to page: v3 stackblitz
  2. See that only the react package is installed and the alerts do not display correctly

Compare this with the following stackblitz, which also has the web-components installed (installed via npm install @ukic/web-components@next), and all is ok here

In v2 it was possible to only install the React package, as per the instructions on the guidance site, and have everything work correctly

📸 Screenshots or code

image

🧐 Expected behaviour

The components should work\appear correctly without needing to install the core web-components package as a dependency manually.

Additional info

seems to be caused by the fact that a v3.0.0 release is already on NPM, so where the react package has a dependency on "ukic/web-components": "^3.0.0-alpha.4", it ignores any alpha packages and instead installs that old 3.0.0 version of the web-components

maybe we could use the "next" keyword in our dependencies?

@MI6-255 MI6-255 added this to the PI 10 V3 milestone Jan 8, 2025
@ad9242 ad9242 removed their assignment Jan 13, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 self-assigned this Jan 14, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Jan 14, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from Dev In Progress to In Review in Intelligence Community Design System Jan 15, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from In Review to Dev In Progress in Intelligence Community Design System Jan 15, 2025
@GCHQ-Developer-741 GCHQ-Developer-741 moved this from Dev In Progress to In Review in Intelligence Community Design System Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants