Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ic-dialog] destructive prop description change #3100

Closed
gd2910 opened this issue Jan 28, 2025 · 0 comments
Closed

[ic-dialog] destructive prop description change #3100

gd2910 opened this issue Jan 28, 2025 · 0 comments
Assignees
@srt544
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before

Comments

@gd2910
Copy link
Contributor

gd2910 commented Jan 28, 2025

Summary of the bug

Currently the destructive prop guidance suggests that it will only work with default buttons, but since we now allow slotted content this also applies to that.

Suggestion to remove 'If default buttons are displayed' from prop description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srt544 srt544

Labels
good first issue A good starter issue if you haven't contributed to the ICDS before
Projects
Intelligence Community Design System
Status: Done
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/3100-ic-dialog-destructive-prop-description-change mi6/ic-ui-kit
3 participants
@ad9242 @gd2910 @srt544