Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ic-page-header] bugfix slotted heading aria label #3120

Open
gd2910 opened this issue Jan 30, 2025 · 0 comments
Open

[ic-page-header] bugfix slotted heading aria label #3120

gd2910 opened this issue Jan 30, 2025 · 0 comments
Labels
a11y This addresses accessibility needs and/or concerns good first issue A good starter issue if you haven't contributed to the ICDS before
Milestone
PI 11 V3

Comments

@gd2910
Copy link
Contributor

gd2910 commented Jan 30, 2025

Summary of the bug

Using a slotted heading the aria-label duplicates the navigation landmark aria-label;

Image

Either remove the duplication on line or take a look at the logic that sets a slotted heading to false.
@gd2910 gd2910 added a11y This addresses accessibility needs and/or concerns type: bug 🐛 labels Jan 30, 2025
@MI6-255 MI6-255 added this to the PI 11 V3 milestone Feb 21, 2025
@MI6-255 MI6-255 added good first issue A good starter issue if you haven't contributed to the ICDS before and removed type: bug 🐛 labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y This addresses accessibility needs and/or concerns good first issue A good starter issue if you haven't contributed to the ICDS before
Projects
Intelligence Community Design System
Status: In Refinement
Milestone
PI 11 V3
Development

No branches or pull requests
2 participants
@MI6-255 @gd2910