Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-components): hides tooltips for navigation buttons on menu #1344

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ad9242
Copy link
Contributor

@ad9242 ad9242 commented Dec 28, 2023

Summary of the changes

Hides tooltips for top navigation icon buttons, when on popout menu

Related issue

#1267

Checklist

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • All acceptance criteria reviewed and met.
  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Min/max content examples tested with no loss of content or overflow.
  • Browser support tested (Chrome, Safari, Firefox and Edge).
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
  • All prop combinations work without issue.
  • Changes to docs package checked and committed.

Copy link
Contributor

@jd239 jd239 force-pushed the 1267-nav-buttons-tooltips branch from db90d4a to de13f66 Compare January 2, 2024 09:33
hides tooltips for top navigation icon buttons, when on popout menu

1267
@jd239 jd239 force-pushed the 1267-nav-buttons-tooltips branch from de13f66 to 0ad0151 Compare January 2, 2024 10:01
@jd239 jd239 merged commit a61b448 into develop Jan 2, 2024
4 checks passed
@jd239 jd239 deleted the 1267-nav-buttons-tooltips branch January 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants