Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1348 side nav expanded event should appear in docs #1351

Merged
merged 3 commits into from
Jan 8, 2024
Merged

1348 side nav expanded event should appear in docs #1351

merged 3 commits into from
Jan 8, 2024

Conversation

GCHQ-Developer-530
Copy link
Contributor

Summary of the changes

Update sideNavExpanded and topNavResized to use event decorator in order to appear in docs.

Related issue

#1348

Checklist

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • All acceptance criteria reviewed and met.
  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Min/max content examples tested with no loss of content or overflow.
  • Browser support tested (Chrome, Safari, Firefox and Edge).
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
  • All prop combinations work without issue.
  • Changes to docs package checked and committed.

@GCHQ-Developer-530
fix(react): update sideNavExpanded and topNavResized to work as other…
df4a4cb 
… events

Update sideNavExpanded and topNavResized to work as other events and appear in docs
@GCHQ-Developer-530
fix(web-components): update sideNavExpanded and topNavResized to use …
d5c3eb4 
…event decorator

Update sideNavExpanded and topNavResized to use event decorator and appear in docs

. #1348
@GCHQ-Developer-530
docs(docs): update docs with sideNavExpanded and topNavResized events
259740f 
Update docs with sideNavExpanded and topNavResized events
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1348-side-nav-expanded-event-should-appear-in-docs/web-components
View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1348-side-nav-expanded-event-should-appear-in-docs/react

@GCHQ-Developer-530 GCHQ-Developer-530 marked this pull request as draft January 4, 2024 14:59
@GCHQ-Developer-530 GCHQ-Developer-530 marked this pull request as ready for review January 5, 2024 07:41
@GCHQ-Developer-530 GCHQ-Developer-530 merged commit aad7dbf into develop Jan 8, 2024
16 checks passed
@GCHQ-Developer-530 GCHQ-Developer-530 deleted the 1348-side-nav-expanded-event-should-appear-in-docs branch January 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCHQ-Developer-465 GCHQ-Developer-465 GCHQ-Developer-465 approved these changes

@GCHQ-Developer-741 GCHQ-Developer-741 GCHQ-Developer-741 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GCHQ-Developer-530 @GCHQ-Developer-465 @GCHQ-Developer-741