-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Develop -> V3 Main #2989
Merged
Merged
V3 Develop -> V3 Main #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n image to fix Safari issue Set horizontal card image size directly on image to fix issue in Safari where image was being displayed smaller than it should.
updates nanoid package
updates nanoid package
updates nanoid package
updates nanoid package
updates nanoid package
updates nanoid package
updates nanoid package
…by default Update tree view/tree item to text wrap by default and add truncate tree items/heading prop for truncation behaviour BREAKING CHANGE: Default behaviour for tree view changed from truncation to text wrap . #2895
Update docs with new tree item/tree view prop for truncation
Update tree view/tree item to text wrap by default and add tests
…nput dark mode Update webkit autofill colours for date input dark mode so that it appears correctly after a browser suggestion . #2915
…ies to have dark background Fix monochrome button css issue, and update stories to have dark background
Add icon button loading Cypress tests to capture any issues
test keydown when additional field has focus
fix for when additional field has focus and arrow key is pressed
…ckground fixes components that are displayed on brand coloured background
fixes components that are displayed on brand coloured background
fixes components that are displayed on brand coloured background
Update fonts package to alpha versioning for v3 to stop clashes with v2 releases BREAKING CHANGE: Package version updated to 3.0.0-alpha.0
…ms per page options prop
updates snapshot file for v3 data-table tests
adds test for action element in data-table
docs changes for ic-chip
added prop to change the dismiss label of ic-chip
added tests for custom dismiss label in ic-chip
updates examples after ic-theme prop changes
updates to canary-docs package after ic-theme changes
updates to docs package after ic-theme changes
keeps canary components in sync with changes made to ic-theme component BREAKING CHANGE: change to IcTheme types, now IcBrand
changes to ic-theme component to rename prop and events BREAKING CHANGE: color prop renamed to brandColor icThemeChange event renamed to icBrandChange changes to types: IcThemeForegroundEnum now IcBrandForegroundEnum IcThemeForeground now IcBrandForeground IcThemeForegroundNoDefault now IcBrandForegroundNoDefault IcTheme now IcBrand
changes to tests and storybook examples following changes to ic-theme component BREAKING CHANGE: BREAKING CHANGE: color prop renamed to brandColor icThemeChange event renamed to icBrandChange changes to types: IcThemeForegroundEnum now IcBrandForegroundEnum IcThemeForeground now IcBrandForeground IcThemeForegroundNoDefault now IcBrandForegroundNoDefault IcTheme now IcBrand
…mpty options array Fix ic-select where no options was able to be selected by refactoring customSelectChange function
test to ensure no value is passed in ic-select when 'no options' is selected
Update icon colours for dark mode badge to match the text colour of badges in dark mode . #2910
Update icon colours for dark mode badge and add tests to capture dark mode icons
bumps dates for audit
add Cypress tests for IcTheme
… to include new target key This change also removes the incorrect keys from the example code that seem to have been left over from a copy and paste from a different example. Closes: #2751
…-data-table cell Allow specifying target and rel attribute for the anchor tag in the cell, along with the href. There are existing styles that add a new window icon to the link when the target is "_blank" and so no change is required to achieve that. Ref: #2751
…set to false removed disabled attribute from all components when it is set to false, to ensure screen readers update its status when switching between states
removed attribute when set to false, to force screen readers to update and correctly identify its status
bugfix for when autofocus prop would only work when label was hidden and small prop rename for v3 BREAKING CHANGE: prop rename from auto-focus to autofocus, more closely aligning with native html attribute
added cypress test and react storybook for autofocus attribute
ic-text-field docs update BREAKING CHANGE: prop rename to more closely align with native html attribute
updates contributing guide with info on rebasing a branch when working on a fork
GCHQ-Developer-299
approved these changes
Jan 8, 2025
GCHQ-Developer-847
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to npm version ry.5 => 3.0.0-canary.6 - @ukic/docs: 3.0.0-alpha.5 => 3.0.0-alpha.6 - @