Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-components): selected items with hover state are lined up correctly in nav group #3121

Conversation

srt544
Copy link
Contributor

@srt544 srt544 commented Jan 31, 2025

fix: selected items with hover state are properly lined up within nav group menu

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@srt544 srt544 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch 2 times, most recently from 1a1be57 to 061a217 Compare February 4, 2025 10:00
@srt544 srt544 self-assigned this Feb 4, 2025
@srt544 srt544 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch from 56651e1 to 963dcef Compare February 4, 2025 16:15
@ad9242 ad9242 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch from 963dcef to 87de32e Compare February 5, 2025 08:03
@srt544 srt544 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch from 87de32e to 5c80390 Compare February 6, 2025 11:19
…rectly in nav group

fix: selected items with hover state are properly lined up within nav group menu
@srt544 srt544 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch from 621b242 to 714bf15 Compare February 6, 2025 14:34
@srt544 srt544 force-pushed the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch from 3a1e5a8 to 7e0ec5e Compare February 7, 2025 09:51
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what this PR is fixing - looking at the v3 develop branch this issue is already fixed - see screenshot below:
Screenshot 2025-02-11 at 10 15 54

Is there somewhere else in storybook that I can see where this change has fixed the issue?

@ad9242
Copy link
Contributor

ad9242 commented Feb 11, 2025

@GCHQ-Developer-299 - the issue occured on desktop:

image

@GCHQ-Developer-299 GCHQ-Developer-299 merged commit fda1f1c into v3.0.0/develop Feb 13, 2025
6 checks passed
@GCHQ-Developer-299 GCHQ-Developer-299 deleted the 2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu branch February 13, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ic-navigation-item] selected items with hover state aren't lined up properly within nav group menu
4 participants