Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2704 ic-tree-item: fixing inconsistencies with truncation #3169

Conversation

cd3859
Copy link
Contributor

@cd3859 cd3859 commented Feb 11, 2025

Summary of the changes

Added min-width to item icons to prevent resizing on long text
All other parts of ticket has already been fixed in previous tickets
Comments on guidance site truncation and tooltip issue along with inset issues are now in specific ticket #3171

Related issue

#2704

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@cd3859 cd3859 force-pushed the 2704-ic-tree-item-issues-with-other-elements-when-truncating-a-tree-item branch 2 times, most recently from a0c1d33 to 4600038 Compare February 11, 2025 16:42
@cd3859 cd3859 marked this pull request as ready for review February 11, 2025 16:43
added styling to correct icon changing position and size and added functionality to handle
truncating tree items before first render
@cd3859 cd3859 force-pushed the 2704-ic-tree-item-issues-with-other-elements-when-truncating-a-tree-item branch from 4600038 to 3cfe01e Compare February 12, 2025 14:37
@ad9242 ad9242 force-pushed the v3.0.0/develop branch 2 times, most recently from fa8f16c to 8f687d3 Compare February 12, 2025 16:22
@ad9242 ad9242 merged commit 40bf864 into v3.0.0/develop Feb 14, 2025
8 checks passed
@ad9242 ad9242 deleted the 2704-ic-tree-item-issues-with-other-elements-when-truncating-a-tree-item branch February 14, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants